Skip to content

Fix: cert-auth allowed_organizational_units handling - #1496

Merged
benashz merged 1 commit into
mainfrom
VAULT-5852/fix-up-for-cert-auth-updates
Jun 9, 2022
Merged

Fix: cert-auth allowed_organizational_units handling#1496
benashz merged 1 commit into
mainfrom
VAULT-5852/fix-up-for-cert-auth-updates

Conversation

@benashz

@benashz benashz commented Jun 9, 2022

Copy link
Copy Markdown
Collaborator

This PR fixes the following issues with the cert_auth_backend_role resource:

  • allowed_organizational_units is not a Computed value
  • add tests to ensure that allowed_organizational_units field is properly
    handled for all lifecycle changes.
  • update docs

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #397 #507 #786

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Add tests to ensure that allowed_organizational_units field is properly
handled for all lifecycle changes.
@benashz
benashz force-pushed the VAULT-5852/fix-up-for-cert-auth-updates branch from af6a162 to e9d5992 Compare June 9, 2022 19:16
@benashz
benashz merged commit 70a1872 into main Jun 9, 2022
@benashz
benashz deleted the VAULT-5852/fix-up-for-cert-auth-updates branch June 9, 2022 21:21
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
Add tests to ensure that allowed_organizational_units field is properly
handled for all lifecycle changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants