Skip to content

Add support for KV Secret Engine resources to move away from vault_generic_secret - #1457

Merged
vinay-gopalan merged 53 commits into
mainfrom
VAULT-1336/support-kv-list
Jun 14, 2022
Merged

Add support for KV Secret Engine resources to move away from vault_generic_secret#1457
vinay-gopalan merged 53 commits into
mainfrom
VAULT-1336/support-kv-list

Conversation

@vinay-gopalan

@vinay-gopalan vinay-gopalan commented May 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds 3 new resources — vault_kv_secret, vault_kv_secret_v2 and vault_kv_secret_backend_v2 — as well as 5 new data sources — vault_kv_secret, vault_kv_secret_v2, vault_kv_secrets_list, vault_kv_secrets_list_v2 and vault_kv_secret_subkeys_v2 that enable users fully configure secrets for and retrieve secrets from KV V1 and V2 Secret Engines.

Resolves: #1033 #57

make testacc TESTARGS='-v -run TestDataSourceKV' 
=== RUN   TestDataSourceKVSecretList
--- PASS: TestDataSourceKVSecretList (1.95s)
=== RUN   TestDataSourceKVSecretListV2
--- PASS: TestDataSourceKVSecretListV2 (3.55s)
=== RUN   TestDataSourceKVSecret
--- PASS: TestDataSourceKVSecret (1.89s)
=== RUN   TestDataSourceKVV2Secret
--- PASS: TestDataSourceKVV2Secret (1.85s)
=== RUN   TestDataSourceKVSubkeys_basic
--- PASS: TestDataSourceKVSubkeys_basic (1.87s)
PASS

make testacc TESTARGS='-v -run TestAccKV'
=== RUN   TestAccKVSecretBackendV2_basic
--- PASS: TestAccKVSecretBackendV2_basic (3.78s)
=== RUN   TestAccKVSecret_basic
--- PASS: TestAccKVSecret_basic (2.06s)
=== RUN   TestAccKVSecretV2_basic
--- PASS: TestAccKVSecretV2_basic (2.07s)
PASS

@github-actions github-actions Bot added size/L and removed size/XL labels May 18, 2022
@github-actions github-actions Bot added size/XL and removed size/L labels May 19, 2022
@vinay-gopalan
vinay-gopalan requested a review from benashz May 19, 2022 22:15
benashz
benashz reviewed May 20, 2022
View reviewed changes

@benashz benashz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Have some suggestions/questions...

Comment thread website/docs/d/generic_secret_list.html.md Outdated
Comment thread vault/data_source_generic_secret_list.go Outdated
Comment thread vault/data_source_generic_secret_list.go Outdated
Comment thread vault/data_source_generic_secret_list.go Outdated
Comment thread vault/data_source_generic_secret_list.go Outdated
Comment thread website/docs/d/generic_secret_list_v2.html.md Outdated
Comment thread vault/data_source_generic_secret_list_test.go Outdated
PreCheck: func() { testutil.TestAccPreCheck(t) },
Steps: []resource.TestStep{
{
Config: testDataSourceGenericSecretListConfig(mount, s1, s2, true),

@benashz benashz May 20, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test the failure modes as well?

Comment thread vault/data_source_generic_secret_list_test.go Outdated
Comment thread website/docs/d/generic_secret_list.html.md Outdated
Comment thread website/docs/d/generic_secret_list_v2.html.md Outdated
@vinay-gopalan vinay-gopalan changed the title Add support to list generic secrets Add support for KV Secret Engine resources to move away from generic_secret Jun 3, 2022
@vinay-gopalan vinay-gopalan changed the title Add support for KV Secret Engine resources to move away from generic_secret Add support for KV Secret Engine resources to move away from vault_generic_secret Jun 3, 2022
benashz
benashz reviewed Jun 3, 2022
View reviewed changes

@benashz benashz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial suggestions.

Comment thread vault/data_source_kv_secret.go Outdated
Comment thread vault/data_source_kv_secret.go Outdated
Comment thread vault/data_source_kv_secret.go Outdated
Comment thread vault/data_source_kv_secret_list.go Outdated
Comment thread vault/data_source_kv_secret_list.go Outdated
Comment thread vault/data_source_kv_secret_list_test.go Outdated
Comment thread vault/data_source_kv_secret_list_test.go Outdated
Comment thread vault/data_source_kv_secret_list_test.go Outdated
@vinay-gopalan
vinay-gopalan requested a review from benashz June 13, 2022 20:58
benashz
benashz reviewed Jun 14, 2022
View reviewed changes
Comment thread vault/data_source_kv_subkeys_v2.go Outdated
Comment thread vault/data_source_kv_subkeys_v2.go Outdated
Comment thread vault/data_source_kv_subkeys_v2.go Outdated
Comment thread vault/data_source_kv_secret_test.go
Comment thread vault/data_source_kv_secret_v2.go Outdated
Comment thread vault/data_source_kv_secret_v2.go Outdated
Comment thread vault/resource_kv_secret.go Outdated
Comment thread vault/resource_kv_secret.go Outdated
Comment thread vault/resource_kv_secret_backend_v2_test.go Outdated
Comment thread vault/resource_kv_secret_v2_test.go Outdated
vinay-gopalan and others added 10 commits June 14, 2022 10:17
@vinay-gopalan @benashz
Update vault/data_source_kv_secret_v2.go
cb07b45 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@vinay-gopalan @benashz
Update vault/data_source_kv_secret_v2.go
ac8bb10 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@vinay-gopalan @benashz
Update vault/resource_kv_secret_v2_test.go
ecc13e4 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@vinay-gopalan @benashz
Update vault/resource_kv_secret_backend_v2_test.go
e1039be 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@vinay-gopalan @benashz
Update vault/resource_kv_secret.go
794a139 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@vinay-gopalan
add constants for depth and data_json
ce4f799
@vinay-gopalan
add error messaging and update test names
e1f1bfa
@vinay-gopalan
Merge branch 'VAULT-1336/support-kv-list' of github.com:hashicorp/ter…
48f131f 
…raform-provider-vault into VAULT-1336/support-kv-list
@vinay-gopalan
update subkeys test name
106ef58
@vinay-gopalan
convert computed data for datasource to TypeString instead of map
1fe0704
@vinay-gopalan
vinay-gopalan requested a review from benashz June 14, 2022 18:01
benashz
benashz approved these changes Jun 14, 2022
View reviewed changes

@benashz benashz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just few minor issues to address, then +1

Comment thread vault/data_source_kv_secret_test.go
Comment thread website/docs/d/generic_secret_list.html.md Outdated
Comment thread website/docs/d/generic_secret_list_v2.html.md Outdated
Comment thread website/vault.erb Outdated
Comment thread website/vault.erb Outdated
@vinay-gopalan
vinay-gopalan merged commit 1593e86 into main Jun 14, 2022
@vinay-gopalan
vinay-gopalan deleted the VAULT-1336/support-kv-list branch June 14, 2022 20:09
@benashz benashz mentioned this pull request Jun 14, 2022
Closed
@vinay-gopalan vinay-gopalan added this to the 3.7.0 milestone Jun 15, 2022
This was referenced Jul 22, 2022
Closed
Closed
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@vinay-gopalan marcboudreau
Add support for KV Secret Engine resources to move away from `vault_g…
33152ca 
…eneric_secret` (hashicorp#1457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benashz benashz benashz approved these changes

Assignees

No one assigned

Labels

documentation size/XL

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

feature request: terraform data source that is equivalent to VAULT KV LIST

2 participants

@vinay-gopalan @benashz