Improve generic secrets data doc - #1390
Merged
Merged
Conversation
HestefaniRomao
approved these changes
Mar 25, 2022
vinay-gopalan
approved these changes
May 4, 2022
vinay-gopalan
left a comment
vinay-gopalan
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thanks for the PR and your contribution to HashiCorp!
marcboudreau
pushed a commit
to marcboudreau/terraform-provider-vault
that referenced
this pull request
Nov 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to use this data resource, I've struggled a little to understand how to use it for KV secrets engine. After a bit of reading and unsuccesful attempts, I've noticed that other users are getting confused by the docs (#470).
This PR improves the documentation by adding a new example for KV engine.
Community Note
Relates OR Closes #470
Release note for CHANGELOG:
Output from acceptance testing: