Handle the case where member_identity_ids might be nil - #1356
Merged
Merged
Conversation
During a plan operation the identity_group_member_entity_ids resource reads the target identity group from Vault. If the identity group exists, and the resource is configured in non-exclusive mode, the resource fails to check the result of the type assertion. This results in an interface conversion panic. Fix is to check the type assertion before further processing of the identity group's member_identity_ids field.
benashz
changed the title
vinay-gopalan
approved these changes
Feb 23, 2022
benashz
added a commit
that referenced
this pull request
Feb 25, 2022
benashz
added a commit
that referenced
this pull request
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a plan operation the
identity_group_member_entity_idsresourcereads the target identity group from Vault. If the identity group
exists, and the resource is configured in non-exclusive mode, the
resource fails to check the result of the type assertion. This results
in an interface conversion panic.
Fix is to check the type assertion before further processing of the
identity group's
member_identity_idsfield.Community Note
Closes #1354
Release note for CHANGELOG:
Output from acceptance testing: