Skip to content

Fix persistent diff for kubernetes_ca_cert in k8s-auth-config - #1337

Merged
benashz merged 2 commits into
mainfrom
VAULT-5063/fix-persistent-diff-in-k8s-auth-config
Feb 10, 2022
Merged

Fix persistent diff for kubernetes_ca_cert in k8s-auth-config#1337
benashz merged 2 commits into
mainfrom
VAULT-5063/fix-persistent-diff-in-k8s-auth-config

Conversation

@benashz

@benashz benashz commented Feb 9, 2022

Copy link
Copy Markdown
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #904

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-v -test.run TestAccKubernetesAuth'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v -v -test.run TestAccKubernetesAuth -timeout 30m ./...

[...]

ok      github.com/hashicorp/terraform-provider-vault/util      (cached) [no tests to run]
=== RUN   TestAccKubernetesAuthBackendConfigDataSource_basic
--- PASS: TestAccKubernetesAuthBackendConfigDataSource_basic (3.32s)
=== RUN   TestAccKubernetesAuthBackendConfigDataSource_full
--- PASS: TestAccKubernetesAuthBackendConfigDataSource_full (3.05s)
=== RUN   TestAccKubernetesAuthBackendRoleDataSource_basic
--- PASS: TestAccKubernetesAuthBackendRoleDataSource_basic (1.82s)
=== RUN   TestAccKubernetesAuthBackendRoleDataSource_full
--- PASS: TestAccKubernetesAuthBackendRoleDataSource_full (1.79s)
=== RUN   TestAccKubernetesAuthBackendConfig_import
--- PASS: TestAccKubernetesAuthBackendConfig_import (13.00s)
=== RUN   TestAccKubernetesAuthBackendConfig_basic
--- PASS: TestAccKubernetesAuthBackendConfig_basic (1.75s)
=== RUN   TestAccKubernetesAuthBackendConfig_update
--- PASS: TestAccKubernetesAuthBackendConfig_update (3.05s)
=== RUN   TestAccKubernetesAuthBackendConfig_full
--- PASS: TestAccKubernetesAuthBackendConfig_full (1.74s)
=== RUN   TestAccKubernetesAuthBackendConfig_fullUpdate
--- PASS: TestAccKubernetesAuthBackendConfig_fullUpdate (4.38s)
=== RUN   TestAccKubernetesAuthBackendConfig_localCA
--- PASS: TestAccKubernetesAuthBackendConfig_localCA (3.00s)
=== RUN   TestAccKubernetesAuthBackendRole_import
--- PASS: TestAccKubernetesAuthBackendRole_import (2.16s)
=== RUN   TestAccKubernetesAuthBackendRole_basic
--- PASS: TestAccKubernetesAuthBackendRole_basic (1.72s)
=== RUN   TestAccKubernetesAuthBackendRole_update
--- PASS: TestAccKubernetesAuthBackendRole_update (3.10s)
=== RUN   TestAccKubernetesAuthBackendRole_full
--- PASS: TestAccKubernetesAuthBackendRole_full (1.71s)
=== RUN   TestAccKubernetesAuthBackendRole_fullUpdate
--- PASS: TestAccKubernetesAuthBackendRole_fullUpdate (6.91s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     56.008s

...

@benashz
benashz requested a review from vinay-gopalan February 9, 2022 23:40

@vinay-gopalan vinay-gopalan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Encountered a failing test when running locally, and left a suggested change

Comment thread vault/resource_kubernetes_auth_backend_config_test.go
Comment thread vault/resource_kubernetes_auth_backend_config_test.go
@benashz
benashz merged commit 08f0c7f into main Feb 10, 2022
@benashz
benashz deleted the VAULT-5063/fix-persistent-diff-in-k8s-auth-config branch February 10, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vault_kubernetes_auth_backend_config tries to remove kubernetes_ca_cert field on subsequent applies

2 participants