Skip to content

Include support to delete key metadata for kv-v2 generic secrets - #1254

Merged
vinay-gopalan merged 12 commits into
mainfrom
feature/kvv2-delete-all
Dec 17, 2021
Merged

Include support to delete key metadata for kv-v2 generic secrets#1254
vinay-gopalan merged 12 commits into
mainfrom
feature/kvv2-delete-all

Conversation

@vinay-gopalan

@vinay-gopalan vinay-gopalan commented Dec 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes
#760
https://hashicorp.atlassian.net/browse/VAULT-4351

Release note for CHANGELOG:

resource/generic_secret: Add support for deleting key metadata and all version data for a secret

Output from acceptance testing:

$ make testacc TESTARGS='-v -run TestResourceGenericSecret'
=== RUN   TestResourceGenericSecret
--- PASS: TestResourceGenericSecret (3.29s)
=== RUN   TestResourceGenericSecret_deleted
--- PASS: TestResourceGenericSecret_deleted (3.01s)
=== RUN   TestResourceGenericSecret_deleteAllVersions
--- PASS: TestResourceGenericSecret_deleteAllVersions (2.95s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     9.412s

@vinay-gopalan
vinay-gopalan requested a review from benashz December 8, 2021 22:13
@vinay-gopalan vinay-gopalan added this to the 3.1.0 milestone Dec 8, 2021
benashz
benashz requested changes Dec 14, 2021
View reviewed changes

@benashz benashz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions/requests.

Comment thread vault/resource_generic_secret_test.go Outdated
Comment thread vault/resource_generic_secret_test.go Outdated
Comment thread vault/resource_generic_secret_test.go Outdated
Comment thread website/docs/r/generic_secret.html.md
@benashz benashz mentioned this pull request Dec 14, 2021
Closed
@github-actions github-actions Bot added size/L and removed size/M labels Dec 16, 2021
benashz
benashz requested changes Dec 17, 2021
View reviewed changes

@benashz benashz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A few suggestions.

Comment thread vault/resource_generic_secret.go
Comment thread vault/resource_generic_secret_test.go Outdated
Comment thread vault/resource_generic_secret_test.go Outdated
Comment thread CHANGELOG.md Outdated
benashz
benashz reviewed Dec 17, 2021
View reviewed changes

@benashz benashz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last suggestion :)

Comment thread vault/resource_generic_secret_test.go Outdated
benashz
benashz approved these changes Dec 17, 2021
View reviewed changes

@benashz benashz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinay-gopalan
vinay-gopalan merged commit 66bba37 into main Dec 17, 2021
@vinay-gopalan
vinay-gopalan deleted the feature/kvv2-delete-all branch December 17, 2021 22:27
@rosezafar rosezafar mentioned this pull request Jan 10, 2022
Closed
@g-psantos g-psantos mentioned this pull request Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benashz benashz benashz approved these changes

Assignees

No one assigned

Labels

documentation feature-parity size/L

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@vinay-gopalan @benashz