Skip to content

Update changelog and add tests for the generic_secret data source. - #1216

Merged
benashz merged 5 commits into
mainfrom
add-tests-changelog-for-770
Nov 5, 2021
Merged

Update changelog and add tests for the generic_secret data source.#1216
benashz merged 5 commits into
mainfrom
add-tests-changelog-for-770

Conversation

@benashz

@benashz benashz commented Nov 5, 2021

Copy link
Copy Markdown
Collaborator

This PR adds test for the generic_secret's lease_start_time field. Its value is now stored in UTC.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #770

Release note for CHANGELOG:


Output from acceptance testing:

make dev testacc TESTARGS='-v -test.run TestDataSource.*Secret' TF_LOG=error
==> Checking that code complies with gofmt requirements...
go build -o terraform-provider-vault
mv terraform-provider-vault ~/.terraform.d/plugins/
TF_ACC=1 go test $(go list ./...) -v -v -test.run TestDataSource.*Secret -timeout 20m

[...]

=== RUN   TestDataSourceGenericSecret
--- PASS: TestDataSourceGenericSecret (2.21s)
=== RUN   TestDataSourceGenericSecret_v2
--- PASS: TestDataSourceGenericSecret_v2 (4.65s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     7.504s
...

@tomhjp tomhjp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nits

Comment thread website/docs/d/generic_secret.html.md Outdated
Comment thread vault/data_source_generic_secret_test.go Outdated
benashz and others added 2 commits November 5, 2021 11:40
Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
@benashz
benashz merged commit b46583e into main Nov 5, 2021
@benashz
benashz deleted the add-tests-changelog-for-770 branch November 5, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants