Add allowed_serial_numbers support - #1119
Closed
axolotlgeoff wants to merge 2 commits into
Closed
Conversation
vinay-gopalan
requested changes
May 2, 2022
vinay-gopalan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for submitting this PR and apologies for the delay! The PR is looking great!
vinay-gopalan
approved these changes
May 6, 2022
vinay-gopalan
left a comment
Contributor
There was a problem hiding this comment.
LGTM after merging commits, thanks for your contribution to HashiCorp!
Contributor
|
Since CI tests are failing due to this branch being on an older version of the codebase, the work has been taken over in a new PR forked from this branch. Closing this PR with #1441 Thanks once again for your contribution to HashiCorp! |
vinay-gopalan
added a commit
that referenced
this pull request
May 9, 2022
Co-authored-by: Geoff Childs <geoff.childs@adalpha.io>
marcboudreau
pushed a commit
to marcboudreau/terraform-provider-vault
that referenced
this pull request
Nov 6, 2022
…rp#1441) Co-authored-by: Geoff Childs <geoff.childs@adalpha.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the
allowed_serial_numberssetting in thevault_pki_secret_backend_roleresource.Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: