Skip to content

kubernetes auth role: allow unset audience - #1022

Merged
tvoran merged 1 commit into
hashicorp:masterfrom
davidmontoyago:kube-auth-audience
May 19, 2021
Merged

kubernetes auth role: allow unset audience#1022
tvoran merged 1 commit into
hashicorp:masterfrom
davidmontoyago:kube-auth-audience

Conversation

@davidmontoyago

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #868

Release note for CHANGELOG:

resource/vault_kubernetes_auth_backend_role: allow unset audience.

Output from acceptance testing:

TF_ACC=1 go test -v github.com/hashicorp/terraform-provider-vault/vault -run TestAccKubernetesAuthBackendRole_fullUpdate

--- PASS: TestAccKubernetesAuthBackendRole_fullUpdate (43.02s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     43.581s
...

@ghost ghost added size/S labels Apr 11, 2021
@tvoran
tvoran self-requested a review May 8, 2021 00:36

@tvoran tvoran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks!

@tvoran
tvoran merged commit 01a25f5 into hashicorp:master May 19, 2021
davidmontoyago added a commit to davidmontoyago/terraform-provider-vault that referenced this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vault_kubernetes_auth_backend_role audience field cannot be unset

2 participants