feat(bedrockagentcore): Memory and Memory Strategy resources - #44306
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
46031ac to
6387ef6
Compare
59631cc to
0a41e1d
Compare
0a41e1d to
bfc924e
Compare
…f-bedrockagentcore-memory # Conflicts: # internal/service/bedrockagentcore/exports_test.go # internal/service/bedrockagentcore/memory_strategy.go # internal/service/bedrockagentcore/memory_strategy_test.go # internal/service/bedrockagentcore/service_package_gen.go # internal/service/bedrockagentcore/sweep.go
ce8463b to
76c3b7f
Compare
% make testacc TESTARGS='-run=TestAccBedrockAgentCoreMemory_' PKG=bedrockagentcore make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 HEAD 🌿... TF_ACC=1 go1.24.6 test ./internal/service/bedrockagentcore/... -v -count 1 -parallel 20 -run=TestAccBedrockAgentCoreMemory_ -timeout 360m -vet=off 2025/10/09 14:59:34 Creating Terraform AWS Provider (SDKv2-style)... 2025/10/09 14:59:34 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccBedrockAgentCoreMemory_basic === PAUSE TestAccBedrockAgentCoreMemory_basic === RUN TestAccBedrockAgentCoreMemory_tags === PAUSE TestAccBedrockAgentCoreMemory_tags === RUN TestAccBedrockAgentCoreMemory_disappears === PAUSE TestAccBedrockAgentCoreMemory_disappears === CONT TestAccBedrockAgentCoreMemory_basic === CONT TestAccBedrockAgentCoreMemory_disappears === CONT TestAccBedrockAgentCoreMemory_tags --- PASS: TestAccBedrockAgentCoreMemory_basic (16.78s) --- PASS: TestAccBedrockAgentCoreMemory_disappears (17.69s) --- PASS: TestAccBedrockAgentCoreMemory_tags (47.59s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagentcore 53.249s
johnsonaj
left a comment
There was a problem hiding this comment.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccBedrockAgentCoreMemory_' PKG=bedrockagentcore
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-bedrockagentcore-memory 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/bedrockagentcore/... -v -count 1 -parallel 20 -run=TestAccBedrockAgentCoreMemory_ -timeout 360m -vet=off
2025/10/22 13:33:44 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/22 13:33:44 Initializing Terraform AWS Provider (SDKv2-style)...
--- PASS: TestAccBedrockAgentCoreMemory_tags_DefaultTags_emptyProviderOnlyTag (229.31s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_ComputedTag_OnUpdate_Replace (243.09s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_DefaultTags_nullNonOverlappingResourceTag (246.97s)
--- PASS: TestAccBedrockAgentCoreMemory_disappears (248.05s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_ComputedTag_OnCreate (253.60s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_EmptyMap (255.96s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_DefaultTags_emptyResourceTag (264.70s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_AddOnUpdate (268.62s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_null (276.60s)
--- PASS: TestAccBedrockAgentCoreMemory_memoryExecutionRole (280.39s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_ComputedTag_OnUpdate_Add (293.67s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_EmptyTag_OnCreate (298.24s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_DefaultTags_nonOverlapping (313.05s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_DefaultTags_updateToResourceOnly (313.86s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_EmptyTag_OnUpdate_Add (324.11s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_DefaultTags_updateToProviderOnly (335.32s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_IgnoreTags_Overlap_DefaultTag (335.57s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_EmptyTag_OnUpdate_Replace (345.89s)
--- PASS: TestAccBedrockAgentCoreMemory_tags (357.06s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_DefaultTags_providerOnly (367.27s)
--- PASS: TestAccBedrockAgentCoreMemory_basic (221.88s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_DefaultTags_nullOverlappingResourceTag (230.91s)
--- PASS: TestAccBedrockAgentCoreMemory_description (232.49s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_IgnoreTags_Overlap_ResourceTag (248.22s)
--- PASS: TestAccBedrockAgentCoreMemory_tags_DefaultTags_overlapping (273.31s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagentcore 510.740s% make testacc TESTARGS='-run=TestAccBedrockAgentCoreMemoryStrategy_' PKG=bedrockagentcore
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-bedrockagentcore-memory 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/bedrockagentcore/... -v -count 1 -parallel 20 -run=TestAccBedrockAgentCoreMemoryStrategy_ -timeout 360m -vet=off
2025/10/22 13:45:03 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/22 13:45:03 Initializing Terraform AWS Provider (SDKv2-style)...
--- PASS: TestAccBedrockAgentCoreMemoryStrategy_disappears (216.68s)
--- PASS: TestAccBedrockAgentCoreMemoryStrategy_standard (263.04s)
--- PASS: TestAccBedrockAgentCoreMemoryStrategy_custom (288.45s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagentcore 296.260s|
@marcinbelczewski thank you for the contribution! 🎉 |
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
This functionality has been released in v6.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
No changes to security controls in this pull request. The implementation follows standard AWS provider patterns for IAM role assumptions and secure memory storage configurations.
Description
This PR implements Memory resources for Amazon Bedrock AgentCore:
aws_bedrockagentcore_memoryresource for storing conversation context for AI agentsaws_bedrockagentcore_memory_strategyresource used to extract and consolidate memories for long-term storageThese resources enable AI agents to maintain conversational context and build long-term memory capabilities. The memory strategy supports both standard and custom configurations for memory extraction and consolidation.
Dependencies
This PR depends on #43738 which fixes a bug in AutoFlex field matching. Once that PR is merged, this branch will be rebased to remove the fix commit and rely on the trunk version.
Relations
Closes #43424
This PR is part of a series of smaller PRs split from the original large PR #43685:
References
Output from Acceptance Testing