Conversation
Member
|
Note: failing test was not caused by this PR and fixed in #1964. Needs rebase. |
Signed-off-by: Seyed Mohammad Mahdi Hatami <hatamik7@gmail.com>
Member
|
@smmhatami I added a test for your PR, but it seems that combining |
jaylinski
changed the title
Contributor
|
I created PR #2150 which I believe fixes the compilation of |
Contributor
|
This can be closed now that #2150 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to solve Issue 1741. Resolves #1741. just checked if obj is really an object at the errors occurrence line specified in the issue. I hope it helps.