Bump AGP to 9.0.1#408
Open
Falah-Zaidan wants to merge 9 commits into
Open
Conversation
…n, adjust dsl (CommonExtension, TestExtension and LibraryExtension)
Member
|
Rest of the changes look good, but do we need |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Android build configuration to support Android Gradle Plugin (AGP) 9.0.1, including related build-logic DSL adjustments and introducing the KSP plugin aliasing.
Changes:
- Bump AGP version to 9.0.1 and update build-logic DSL usage to match newer AGP APIs.
- Introduce the KSP plugin (via version catalog + module application).
- Remove the Kotlin Android plugin alias/application and remove Compose compiler report configuration.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| android/source/build.gradle.kts | Applies the KSP plugin to the :source module. |
| android/gradle/libs.versions.toml | Bumps AGP version; adds KSP version + plugin; removes Kotlin Android (kgp) + guardian kotlin plugin entries. |
| android/build.gradle.kts | Removes Kotlin Android (kgp) from root plugins; adds KSP plugin (apply false). |
| android/build-logic/convention/src/main/kotlin/com/theguardian/convention/shared/BaseModuleConfig.kt | Updates CommonExtension typing and switches to .apply on defaultConfig. |
| android/build-logic/convention/src/main/kotlin/com/theguardian/convention/shared/AndroidTestsConfig.kt | Updates CommonExtension typing; refactors managed devices DSL; adds (internal) with import. |
| android/build-logic/convention/src/main/kotlin/com/theguardian/convention/shared/AndroidCompose.kt | Updates CommonExtension typing; switches to .apply for buildFeatures; removes compose compiler report config. |
| android/build-logic/convention/src/main/kotlin/com/theguardian/convention/ComposeLibraryConventionPlugin.kt | Updates LibraryExtension import to the new AGP DSL package. |
| android/build-logic/convention/src/main/kotlin/com/theguardian/convention/AndroidTestConventionPlugin.kt | Updates TestExtension import; removes Kotlin Android (kgp) application. |
| android/build-logic/convention/src/main/kotlin/com/theguardian/convention/AndroidLibraryConventionPlugin.kt | Updates LibraryExtension import; removes Kotlin Android (kgp) application. |
| android/build-logic/convention/src/main/kotlin/com/theguardian/convention/AndroidApplicationConventionPlugin.kt | Removes Kotlin Android (kgp) application. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Hey, could we do the ktlint related changes here too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes to bump AGP to 9.0.1.
kotlin-androidplugin (kgp)CommonExtension,TestExtensionandLibraryExtension..applyinbuild.gradle.ktslogickotlinterversion to5.5.0formatKotlincommand and disablektlint_standard_kdocruleTesting notes/instructions: