Skip to content

Bump AGP to 9.0.1#408

Open
Falah-Zaidan wants to merge 9 commits into
mainfrom
bump-agp-version-9.0.1
Open

Bump AGP to 9.0.1#408
Falah-Zaidan wants to merge 9 commits into
mainfrom
bump-agp-version-9.0.1

Conversation

@Falah-Zaidan

@Falah-Zaidan Falah-Zaidan commented Jul 7, 2026

Copy link
Copy Markdown
Member

Description

Changes to bump AGP to 9.0.1.

  • Remove kotlin-android plugin (kgp)
  • Amend DSL CommonExtension, TestExtension and LibraryExtension.
  • Use .apply in build.gradle.kts logic
  • Update kotlinter version to 5.5.0
  • Run the formatKotlin command and disable ktlint_standard_kdoc rule
  • Remove Incompatible report generation
extensions.configure(ComposeCompilerGradlePluginExtension::class.java) {
    reportsDestination.set(layout.buildDirectory.dir("compose_compiler"))
}

Testing notes/instructions:

  • Build and run the sample, give it a quick smoke test.
  • Run all tests locally.

…n, adjust dsl (CommonExtension, TestExtension and LibraryExtension)
@Falah-Zaidan Falah-Zaidan added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Jul 7, 2026
@Falah-Zaidan Falah-Zaidan requested a review from a team as a code owner July 7, 2026 16:51
Copilot AI review requested due to automatic review settings July 7, 2026 16:51
@adi-gnm

adi-gnm commented Jul 7, 2026

Copy link
Copy Markdown
Member

Rest of the changes look good, but do we need ksp here? I can't think of anything in this repo using it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Android build configuration to support Android Gradle Plugin (AGP) 9.0.1, including related build-logic DSL adjustments and introducing the KSP plugin aliasing.

Changes:

  • Bump AGP version to 9.0.1 and update build-logic DSL usage to match newer AGP APIs.
  • Introduce the KSP plugin (via version catalog + module application).
  • Remove the Kotlin Android plugin alias/application and remove Compose compiler report configuration.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
android/source/build.gradle.kts Applies the KSP plugin to the :source module.
android/gradle/libs.versions.toml Bumps AGP version; adds KSP version + plugin; removes Kotlin Android (kgp) + guardian kotlin plugin entries.
android/build.gradle.kts Removes Kotlin Android (kgp) from root plugins; adds KSP plugin (apply false).
android/build-logic/convention/src/main/kotlin/com/theguardian/convention/shared/BaseModuleConfig.kt Updates CommonExtension typing and switches to .apply on defaultConfig.
android/build-logic/convention/src/main/kotlin/com/theguardian/convention/shared/AndroidTestsConfig.kt Updates CommonExtension typing; refactors managed devices DSL; adds (internal) with import.
android/build-logic/convention/src/main/kotlin/com/theguardian/convention/shared/AndroidCompose.kt Updates CommonExtension typing; switches to .apply for buildFeatures; removes compose compiler report config.
android/build-logic/convention/src/main/kotlin/com/theguardian/convention/ComposeLibraryConventionPlugin.kt Updates LibraryExtension import to the new AGP DSL package.
android/build-logic/convention/src/main/kotlin/com/theguardian/convention/AndroidTestConventionPlugin.kt Updates TestExtension import; removes Kotlin Android (kgp) application.
android/build-logic/convention/src/main/kotlin/com/theguardian/convention/AndroidLibraryConventionPlugin.kt Updates LibraryExtension import; removes Kotlin Android (kgp) application.
android/build-logic/convention/src/main/kotlin/com/theguardian/convention/AndroidApplicationConventionPlugin.kt Removes Kotlin Android (kgp) application.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adi-gnm

adi-gnm commented Jul 9, 2026

Copy link
Copy Markdown
Member

Hey, could we do the ktlint related changes here too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants