Skip to content

Simplify mobile-sticky ad styles#16277

Closed
cemms1 wants to merge 2 commits into
mainfrom
cemms1/fix-mobile-sticky-styles
Closed

Simplify mobile-sticky ad styles#16277
cemms1 wants to merge 2 commits into
mainfrom
cemms1/fix-mobile-sticky-styles

Conversation

@cemms1

@cemms1 cemms1 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

What does this change?

Uses the full width design for all mobile-sticky ads across the site rather than using a particular design for some scenarios and not for others

This combines the full width styles with the general styles and removes unnecessary props from the MobileStickyContainer which specify content type

Additionally updated all mobile sticky containers to only render when renderAds is true, since we don't want the slot appearing at all in the DOM where we don't show ads.

Why?

We discovered we were only using the full width designs on certain article types recently and would like a consistent approach across all mobile sticky slots on the site

We already control whether the mobile sticky slot is eligible to be filled in the commercial bundle so the only thing DCR needs to know is how to style the resulting ad slot

Screenshots

Before After
before after

@akash1810

Copy link
Copy Markdown
Member

Please rebase this branch against main. #16321 made some changes to CI and infrastructure. Deploying this branch without these changes present will either:

  • Fail when using Riff-Raff's default update strategy
  • OR delete the new infrastructure

Please rebase this branch against main.

@cemms1 cemms1 closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants