chore(ci): Use GH's setup-node Action - #1062
Merged
Merged
Conversation
Since actions/setup-node#338, GH's setup-node Action understands `.nvmrc` files. This makes our `guardian/actions-setup-node` fork somewhat redundant now. Move to GH's Action so we can deprecate our fork.
Member
Author
|
CI is using node 16.13.0 from our
|
jacobwinch
approved these changes
Jan 28, 2022
Contributor
|
🎉 This PR is included in version 34.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since actions/setup-node#338, GH's setup-node Action understands
.nvmrcfiles. This makes ourguardian/actions-setup-nodefork somewhat redundant now.Move to GH's Action so we can deprecate our fork.
How to test
CI should pass. The build log should also suggest the correct node version is used too.