Skip to content

Pushing column mapping definition to widget's manifest - #235

Merged
berhalak merged 3 commits into
masterfrom
jareks/column-mappings
Aug 31, 2026
Merged

Pushing column mapping definition to widget's manifest#235
berhalak merged 3 commits into
masterfrom
jareks/column-mappings

Conversation

@berhalak

@berhalak berhalak commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Column mappings live in the widget code, inside grist.ready(). Grist only
sees them after the widget loads. An assistant that adds a widget to a page
cannot see them at all, so it cannot map the columns.

This PR adds the mappings to package.json, so they end up in
manifest.json. This is the new place to define columns for a widget.

The old mappings in grist.ready() stay, so nothing breaks. New widgets can
use the manifest only.

Not related: rendervideo used label instead of title, now fixed.

@netlify

netlify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Deploy Preview for boisterous-sunburst-a5c941 ready!

Name Link
🔨 Latest commit 843d0a4
🔍 Latest deploy log https://app.netlify.com/projects/boisterous-sunburst-a5c941/deploys/6a7f1af2d8a9d600088d7962
😎 Deploy Preview https://deploy-preview-235--boisterous-sunburst-a5c941.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@paulfitz
paulfitz self-requested a review August 13, 2026 19:30

@paulfitz paulfitz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @berhalak, looks pretty good.

In passing, could you fix the existing issues of a double grist.ready in flashcards:

  grist.ready({
    columns: [
      { name: "Question", type: 'Text', title: "Question Column"},
      { name: "Answer", type: 'Text', title: "Answer Column"},
    ],
    requiredAccess: 'read table'
  });
  grist.ready();

and in maps/page.js there's a different duplication:

    { name: "Address", type: 'Text', optional, optional},

Comment thread inspect/package.json Outdated
@berhalak
berhalak requested a review from paulfitz August 17, 2026 10:45

@paulfitz paulfitz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @berhalak !

@berhalak
berhalak merged commit 41546b6 into master Aug 31, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants