Skip to content

Clarify handling of null handling within lists#317

Merged
leebyron merged 2 commits intographql:masterfrom
TOTBWF:NonNullList
Jun 20, 2017
Merged

Clarify handling of null handling within lists#317
leebyron merged 2 commits intographql:masterfrom
TOTBWF:NonNullList

Conversation

@TOTBWF
Copy link
Copy Markdown
Contributor

@TOTBWF TOTBWF commented Jun 5, 2017

As it stands, the spec is unclear on what to do when an Non-Null element of a list resolves to null. These changes clarify that the entire list should resolve to null, and to propagate the error upwards

As it stands, the spec is unclear on what to do when an Non-Null element of a list resolves to null. These changes clarify that the entire list should resolve to null, and to propagate the error upwards
@facebook-github-bot
Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@leebyron leebyron merged commit 7cada52 into graphql:master Jun 20, 2017
@leebyron
Copy link
Copy Markdown
Collaborator

Thank you for this clarification. I agree this is a helpful addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants