let GraphQLArgs inherit all parse/validate/execute options#4561
Merged
yaacovCR merged 2 commits intographql:nextfrom Feb 17, 2026
Merged
let GraphQLArgs inherit all parse/validate/execute options#4561yaacovCR merged 2 commits intographql:nextfrom
yaacovCR merged 2 commits intographql:nextfrom
Conversation
|
@yaacovCR is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
yaacovCR
changed the title
Contributor
Author
I think that's ok for now, in a future (major?) change, we need to reorganize all our options and that should help, see comment @ https://github.com/graphql/graphql-js/pull/4364/changes#r2037627873 (you may have to expand resolved/minimized comments to get to see the relevant bit) |
we may have to standardize/change our options handling across the different parse/validate/execute phases
yaacovCR
added a commit
that referenced
this pull request
Feb 22, 2026
motivation: - reduces maintenance burden - increases utility/flexibility of the `graphql` pipeline function potential downside: - means that we have to police any ambiguity or clashes regarding option property names between `ParseOptions`, `ValidationOptions`, and `ExecutionArgs`. This will hopefully be mitigated in the future in the context of an overall option "cleanup" where we: (a) differentiate request/spec defined "options/args" and implementation-specific options (b) further group options, especially with regard to our growing list of execution options and (c) potentially introduce a more standardized namespace/convention for experimental-options.
yaacovCR
added a commit
that referenced
this pull request
Feb 22, 2026
motivation: - reduces maintenance burden - increases utility/flexibility of the `graphql` pipeline function potential downside: - means that we have to police any ambiguity or clashes regarding option property names between `ParseOptions`, `ValidationOptions`, and `ExecutionArgs`. This will hopefully be mitigated in the future in the context of an overall option "cleanup" where we: (a) differentiate request/spec defined "options/args" and implementation-specific options (b) further group options, especially with regard to our growing list of execution options and (c) potentially introduce a more standardized namespace/convention for experimental-options.
yaacovCR
added a commit
that referenced
this pull request
Feb 23, 2026
motivation: - reduces maintenance burden - increases utility/flexibility of the `graphql` pipeline function potential downside: - means that we have to police any ambiguity or clashes regarding option property names between `ParseOptions`, `ValidationOptions`, and `ExecutionArgs`. This will hopefully be mitigated in the future in the context of an overall option "cleanup" where we: (a) differentiate request/spec defined "options/args" and implementation-specific options (b) further group options, especially with regard to our growing list of execution options and (c) potentially introduce a more standardized namespace/convention for experimental-options.
yaacovCR
added a commit
that referenced
this pull request
Feb 23, 2026
motivation: - reduces maintenance burden - increases utility/flexibility of the `graphql` pipeline function potential downside: - means that we have to police any ambiguity or clashes regarding option property names between `ParseOptions`, `ValidationOptions`, and `ExecutionArgs`. This will hopefully be mitigated in the future in the context of an overall option "cleanup" where we: (a) differentiate request/spec defined "options/args" and implementation-specific options (b) further group options, especially with regard to our growing list of execution options and (c) potentially introduce a more standardized namespace/convention for experimental-options.
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
motivation: - reduces maintenance burden - increases utility/flexibility of the `graphql` pipeline function potential downside: - means that we have to police any ambiguity or clashes regarding option property names between `ParseOptions`, `ValidationOptions`, and `ExecutionArgs`. This will hopefully be mitigated in the future in the context of an overall option "cleanup" where we: (a) differentiate request/spec defined "options/args" and implementation-specific options (b) further group options, especially with regard to our growing list of execution options and (c) potentially introduce a more standardized namespace/convention for experimental-options.
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
motivation: - reduces maintenance burden - increases utility/flexibility of the `graphql` pipeline function potential downside: - means that we have to police any ambiguity or clashes regarding option property names between `ParseOptions`, `ValidationOptions`, and `ExecutionArgs`. This will hopefully be mitigated in the future in the context of an overall option "cleanup" where we: (a) differentiate request/spec defined "options/args" and implementation-specific options (b) further group options, especially with regard to our growing list of execution options and (c) potentially introduce a more standardized namespace/convention for experimental-options.
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
motivation: - reduces maintenance burden - increases utility/flexibility of the `graphql` pipeline function potential downside: - means that we have to police any ambiguity or clashes regarding option property names between `ParseOptions`, `ValidationOptions`, and `ExecutionArgs`. This will hopefully be mitigated in the future in the context of an overall option "cleanup" where we: (a) differentiate request/spec defined "options/args" and implementation-specific options (b) further group options, especially with regard to our growing list of execution options and (c) potentially introduce a more standardized namespace/convention for experimental-options.
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
motivation: - reduces maintenance burden - increases utility/flexibility of the `graphql` pipeline function potential downside: - means that we have to police any ambiguity or clashes regarding option property names between `ParseOptions`, `ValidationOptions`, and `ExecutionArgs`. This will hopefully be mitigated in the future in the context of an overall option "cleanup" where we: (a) differentiate request/spec defined "options/args" and implementation-specific options (b) further group options, especially with regard to our growing list of execution options and (c) potentially introduce a more standardized namespace/convention for experimental-options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation:
graphqlpipeline functionpotential downside:
ParseOptions,ValidationOptions, andExecutionArgs.