refactor buildResolveInfo into a lazy class#4530
Merged
yaacovCR merged 2 commits intographql:nextfrom Jan 26, 2026
Merged
Conversation
yaacovCR
added
the
PR: breaking change 💥
|
@yaacovCR is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
yaacovCR
force-pushed
the
resolve-info-class
branch
from
f3ac7dd to
f49db06
Compare
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jan 27, 2026
<img width="840" height="142" alt="image" src="https://github.com/user-attachments/assets/b55da6ae-d50b-40b6-b454-dc949ec4faf0" /> this is a breaking change only because `buildResolveInfo()` is technically accessible via deep import
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Feb 10, 2026
Sadly, this would break existing users that resolver functions by spreading the info argument.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Feb 11, 2026
Sadly, this would break existing users that resolver functions by spreading the info argument.
yaacovCR
added a commit
that referenced
this pull request
Feb 11, 2026
Sadly, this would break existing users that resolver functions by spreading the info argument. BREAKING CHANGE: this PR changes `info.abortSignal` to `info.getAbortSignal()` => while `info` as a whole is not lazy, changing to a method allows us to maintain laziness at least with regards to the creation of the abort signal.
yaacovCR
added a commit
that referenced
this pull request
Feb 22, 2026
<img width="840" height="142" alt="image" src="https://github.com/user-attachments/assets/b55da6ae-d50b-40b6-b454-dc949ec4faf0" /> this is a breaking change only because `buildResolveInfo()` is technically accessible via deep import
yaacovCR
added a commit
that referenced
this pull request
Feb 22, 2026
Sadly, this would break existing users that resolver functions by spreading the info argument. BREAKING CHANGE: this PR changes `info.abortSignal` to `info.getAbortSignal()` => while `info` as a whole is not lazy, changing to a method allows us to maintain laziness at least with regards to the creation of the abort signal.
yaacovCR
added a commit
that referenced
this pull request
Feb 22, 2026
<img width="840" height="142" alt="image" src="https://github.com/user-attachments/assets/b55da6ae-d50b-40b6-b454-dc949ec4faf0" /> this is a breaking change only because `buildResolveInfo()` is technically accessible via deep import
yaacovCR
added a commit
that referenced
this pull request
Feb 22, 2026
Sadly, this would break existing users that resolver functions by spreading the info argument. BREAKING CHANGE: this PR changes `info.abortSignal` to `info.getAbortSignal()` => while `info` as a whole is not lazy, changing to a method allows us to maintain laziness at least with regards to the creation of the abort signal.
yaacovCR
added a commit
that referenced
this pull request
Feb 23, 2026
<img width="840" height="142" alt="image" src="https://github.com/user-attachments/assets/b55da6ae-d50b-40b6-b454-dc949ec4faf0" /> this is a breaking change only because `buildResolveInfo()` is technically accessible via deep import
yaacovCR
added a commit
that referenced
this pull request
Feb 23, 2026
Sadly, this would break existing users that resolver functions by spreading the info argument. BREAKING CHANGE: this PR changes `info.abortSignal` to `info.getAbortSignal()` => while `info` as a whole is not lazy, changing to a method allows us to maintain laziness at least with regards to the creation of the abort signal.
yaacovCR
added a commit
that referenced
this pull request
Feb 23, 2026
Sadly, this would break existing users that resolver functions by spreading the info argument. BREAKING CHANGE: this PR changes `info.abortSignal` to `info.getAbortSignal()` => while `info` as a whole is not lazy, changing to a method allows us to maintain laziness at least with regards to the creation of the abort signal.
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
<img width="840" height="142" alt="image" src="https://github.com/user-attachments/assets/b55da6ae-d50b-40b6-b454-dc949ec4faf0" /> this is a breaking change only because `buildResolveInfo()` is technically accessible via deep import
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
Sadly, this would break existing users that resolver functions by spreading the info argument. BREAKING CHANGE: this PR changes `info.abortSignal` to `info.getAbortSignal()` => while `info` as a whole is not lazy, changing to a method allows us to maintain laziness at least with regards to the creation of the abort signal.
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
<img width="840" height="142" alt="image" src="https://github.com/user-attachments/assets/b55da6ae-d50b-40b6-b454-dc949ec4faf0" /> this is a breaking change only because `buildResolveInfo()` is technically accessible via deep import
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
Sadly, this would break existing users that resolver functions by spreading the info argument. BREAKING CHANGE: this PR changes `info.abortSignal` to `info.getAbortSignal()` => while `info` as a whole is not lazy, changing to a method allows us to maintain laziness at least with regards to the creation of the abort signal.
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
<img width="840" height="142" alt="image" src="https://github.com/user-attachments/assets/b55da6ae-d50b-40b6-b454-dc949ec4faf0" /> this is a breaking change only because `buildResolveInfo()` is technically accessible via deep import
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
Sadly, this would break existing users that resolver functions by spreading the info argument. BREAKING CHANGE: this PR changes `info.abortSignal` to `info.getAbortSignal()` => while `info` as a whole is not lazy, changing to a method allows us to maintain laziness at least with regards to the creation of the abort signal.
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
<img width="840" height="142" alt="image" src="https://github.com/user-attachments/assets/b55da6ae-d50b-40b6-b454-dc949ec4faf0" /> this is a breaking change only because `buildResolveInfo()` is technically accessible via deep import
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
Sadly, this would break existing users that resolver functions by spreading the info argument. BREAKING CHANGE: this PR changes `info.abortSignal` to `info.getAbortSignal()` => while `info` as a whole is not lazy, changing to a method allows us to maintain laziness at least with regards to the creation of the abort signal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a breaking change only because
buildResolveInfo()is technically accessible via deep import