fix(mapAsyncIterable): always close source when mapped iterable is thrown#4494
Merged
yaacovCR merged 2 commits intographql:nextfrom Oct 24, 2025
Merged
fix(mapAsyncIterable): always close source when mapped iterable is thrown#4494yaacovCR merged 2 commits intographql:nextfrom
yaacovCR merged 2 commits intographql:nextfrom
Conversation
yaacovCR
force-pushed
the
always-close
branch
from
b89cdc6 to
fb192be
Compare
…rown Even when the underlying source does not implement a `.throw()` method.
yaacovCR
force-pushed
the
always-close
branch
from
fb192be to
5eee87c
Compare
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
…rown (graphql#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
…rown (graphql#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
…rown (graphql#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 18, 2025
…rown (graphql#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 19, 2025
…rown (graphql#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 22, 2025
…rown (graphql#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
that referenced
this pull request
Dec 22, 2025
…rown (#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
that referenced
this pull request
Dec 22, 2025
…rown (#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jan 27, 2026
…rown (graphql#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
that referenced
this pull request
Feb 22, 2026
…rown (#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
that referenced
this pull request
Feb 22, 2026
…rown (#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
that referenced
this pull request
Feb 23, 2026
…rown (#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
…rown (#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
…rown (#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
…rown (#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
…rown (#4494) Even when the underlying source does not implement a `.throw()` method. Bug fix, but very low impact as `.throw()` should never need be used with our generator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even when the underlying source does not implement a
.throw()method.