Skip to content

Fix incorrect FormattedCompletedResult fields and add a FormattedPendingResult #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoviDeCroock merged 2 commits into from
Sep 22, 2025
Merged

Fix incorrect FormattedCompletedResult fields and add a FormattedPendingResult #4481

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f18b171
Fix FormattedCompletedResult fields. Add FormattedPendingResult
jerelmiller Sep 8, 2025
2091d65
Remove FormattedPendingResult
jerelmiller Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/execution/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export interface FormattedInitialIncrementalExecutionResult<
TExtensions = ObjMap<unknown>,
> extends FormattedExecutionResult<TData, TExtensions> {
data: TData;
pending: ReadonlyArray<PendingResult>;
pending: ReadonlyArray<FormattedPendingResult>;
hasNext: boolean;
extensions?: TExtensions;
}
Expand All @@ -83,7 +83,7 @@ export interface FormattedSubsequentIncrementalExecutionResult<
TExtensions = ObjMap<unknown>,
> {
hasNext: boolean;
pending?: ReadonlyArray<PendingResult>;
pending?: ReadonlyArray<FormattedPendingResult>;
incremental?: ReadonlyArray<FormattedIncrementalResult<TData, TExtensions>>;
completed?: ReadonlyArray<FormattedCompletedResult>;
extensions?: TExtensions;
Expand Down Expand Up @@ -156,15 +156,20 @@ export interface PendingResult {
label?: string;
}

export interface FormattedPendingResult {
Comment thread
JoviDeCroock marked this conversation as resolved.
Outdated
id: string;
path: ReadonlyArray<string | number>;
label?: string;
}

export interface CompletedResult {
id: string;
errors?: ReadonlyArray<GraphQLError>;
}

export interface FormattedCompletedResult {
path: ReadonlyArray<string | number>;
label?: string;
errors?: ReadonlyArray<GraphQLError>;
id: string;
errors?: ReadonlyArray<GraphQLFormattedError>;
}

export function isPendingExecutionGroup(
Expand Down