Skip to content

predicates: replace instanceof with symbol based brand check#4468

Merged
yaacovCR merged 4 commits intographql:nextfrom
yaacovCR:use-brand
Aug 8, 2025
Merged

predicates: replace instanceof with symbol based brand check#4468
yaacovCR merged 4 commits intographql:nextfrom
yaacovCR:use-brand

Conversation

@yaacovCR
Copy link
Copy Markdown
Contributor

@yaacovCR yaacovCR commented Aug 6, 2025 •
edited
Loading

This PR updates our predicates to rely on a brand check rather than instanceof.

We still pass brand check to our instanceOf utility and in development mode use the same logic as previously to throw our error with multiple instances of graphql.

@yaacovCR yaacovCR requested a review from a team as a code owner August 6, 2025 10:23
@yaacovCR
Copy link
Copy Markdown
Contributor Author

yaacovCR commented Aug 6, 2025

image

@yaacovCR yaacovCR added the PR: feature 🚀 requires increase of "minor" version number label Aug 6, 2025
@yaacovCR yaacovCR force-pushed the use-brand branch 4 times, most recently from 5c673b9 to cfb5e91 Compare August 8, 2025 09:55
JoviDeCroock
JoviDeCroock reviewed Aug 8, 2025
View reviewed changes
Comment thread src/jsutils/instanceOf.ts Outdated
@yaacovCR yaacovCR changed the title predicates: use brand check in production predicates: use symbol based brand check instead of instanceof Aug 8, 2025
@yaacovCR yaacovCR changed the title predicates: use symbol based brand check instead of instanceof predicates: replace instanceof with symbol based brand check Aug 8, 2025
@yaacovCR yaacovCR merged commit 02d302e into graphql:next Aug 8, 2025
16 checks passed
@yaacovCR yaacovCR deleted the use-brand branch August 8, 2025 19:14
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
predicates: replace instanceof with symbol based brand check (graphql…
4de398c 
…#4468)

This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
predicates: replace instanceof with symbol based brand check (graphql…
6a446d4 
…#4468)

This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025
@yaacovCR
predicates: replace instanceof with symbol based brand check (graphql…
48ac759 
…#4468)

This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 18, 2025
@yaacovCR
predicates: replace instanceof with symbol based brand check (graphql…
f3bae9d 
…#4468)

This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 19, 2025
@yaacovCR
predicates: replace instanceof with symbol based brand check (graphql…
7d6aeea 
…#4468)

This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 22, 2025
@yaacovCR
predicates: replace instanceof with symbol based brand check (graphql…
a2f3e08 
…#4468)

This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit that referenced this pull request Dec 22, 2025
@yaacovCR
predicates: replace instanceof with symbol based brand check (#4468)
ec7b58d 
This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit that referenced this pull request Dec 22, 2025
@yaacovCR
predicates: replace instanceof with symbol based brand check (#4468)
61e1764 
This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Jan 27, 2026
@yaacovCR
predicates: replace instanceof with symbol based brand check (graphql…
bbafb77 
…#4468)

This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit that referenced this pull request Feb 22, 2026
@yaacovCR
predicates: replace instanceof with symbol based brand check (#4468)
1f5cff8 
This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit that referenced this pull request Feb 23, 2026
@yaacovCR
predicates: replace instanceof with symbol based brand check (#4468)
8dcbb71 
This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit that referenced this pull request Feb 24, 2026
@yaacovCR
predicates: replace instanceof with symbol based brand check (#4468)
3dc6ba8 
This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit that referenced this pull request Feb 24, 2026
@yaacovCR
predicates: replace instanceof with symbol based brand check (#4468)
f51509b 
This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit that referenced this pull request Feb 24, 2026
@yaacovCR
predicates: replace instanceof with symbol based brand check (#4468)
6c107ef 
This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR added a commit that referenced this pull request Feb 24, 2026
@yaacovCR
predicates: replace instanceof with symbol based brand check (#4468)
e7604fd 
This PR updates our predicates to rely on a brand check rather than `instanceof`.

We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
@yaacovCR yaacovCR mentioned this pull request Mar 5, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saihaj saihaj saihaj approved these changes

+1 more reviewer

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: feature 🚀 requires increase of "minor" version number

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yaacovCR @JoviDeCroock @saihaj