Skip to content

Validate against @stream on different instances of the same field#4342

Merged
yaacovCR merged 1 commit intomainfrom
robrichard/validate-stream
Feb 12, 2025
Merged

Validate against @stream on different instances of the same field#4342
yaacovCR merged 1 commit intomainfrom
robrichard/validate-stream

Conversation

@robrichard
Copy link
Copy Markdown
Contributor

@robrichard robrichard requested a review from a team as a code owner February 7, 2025 20:21
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 7, 2025

Hi @robrichard, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@robrichard robrichard force-pushed the robrichard/validate-stream branch from 8dc826b to fa763b1 Compare February 7, 2025 20:25
Copy link
Copy Markdown
Contributor

@yaacovCR yaacovCR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one small error message suggestion, otherwise looks good.

Comment thread src/validation/rules/OverlappingFieldsCanBeMergedRule.ts Outdated
@robrichard robrichard force-pushed the robrichard/validate-stream branch from fa763b1 to c4532e9 Compare February 10, 2025 14:23
@JoviDeCroock JoviDeCroock added the PR: breaking change 💥 implementation requires increase of "major" version number label Feb 12, 2025
@yaacovCR yaacovCR merged commit 72c9044 into main Feb 12, 2025
@yaacovCR yaacovCR deleted the robrichard/validate-stream branch February 12, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: breaking change 💥 implementation requires increase of "major" version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants