feat: Allow skipping suggestions

[JoviDeCroock]

Resolves #4190
Resolves #2247
Supersedes #3467

This is a best practice already in production however GraphQL JS does not provide an out of the box solution. In the community we have solutions like https://escape.tech/graphql-armor/docs/plugins/block-field-suggestions/ however in v17 it would be worth considering providing a built-in.

The recommendation here would be to do validate(schema, doc, rules, { hideSuggestions: process.env.NODE_ENV === 'production' })

[netlify]

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name	Link
🔨 Latest commit	00a01cf
🔍 Latest deploy log	https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6707d7fdc530950008c1211f
😎 Deploy Preview	https://deploy-preview-4214--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

• @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
• @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

[yaacovCR]

It looks like calls to didYouMean() also show up within execute(...), namely coerceInputValue() via GraphQLEnumType.parseValue() and unknown input fields on a GraphQLInputObjectType. So we may need a fourth argument to coerceInputValue() that is then passed along as a second argument to GraphQLEnumType.parseValue()? That would cause the signature of parseValue() to be different for scalars than enums => which could be avoided by passing the new argument also to scalars. The specified scalars don't give suggestions, but perhaps some custom scalars do (???) and maybe this argument could be useful. Otherwise, we could just diverge between enums and custom scalars.

[JoviDeCroock]

@yaacovCR added it for enums/scalars, just need to add tests now

[yaacovCR]

I think this has been a much-requested feature! Amazing! Left some comments in terms of some suggestions, basically I am hopeful that we can make this non-breaking in terms of function signatures, even though of course it's going in v17, so we could break things if we need to.

[yaacovCR]

The recommendation here would be to do validate(schema, doc, rules, { maskSuggestions: process.env.NODE_ENV === 'production' })

Or validate(schema, doc, rules, { maskSuggestions: process.env.NODE_ENV !== 'development' })

[yaacovCR]

I added some thoughts in #4219