Skip to content

FIX:Support for bigint in ID.#3973

Closed
xonx4l wants to merge 1 commit intographql:mainfrom
xonx4l:patch-1
Closed

FIX:Support for bigint in ID.#3973
xonx4l wants to merge 1 commit intographql:mainfrom
xonx4l:patch-1

Conversation

@xonx4l
Copy link
Copy Markdown

@xonx4l xonx4l commented Oct 6, 2023

ISSUE-:#3913

@linux-foundation-easycla
Copy link
Copy Markdown

CLA Not Signed

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 6, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 3bb4cd4
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/65206184d894bc000818cd74
😎 Deploy Preview https://deploy-preview-3973--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yaacovCR
Copy link
Copy Markdown
Contributor

yaacovCR commented Oct 1, 2024

Closing this for now in favor of somewhat more comprehensive #4088

@yaacovCR yaacovCR closed this Oct 1, 2024
@yaacovCR yaacovCR mentioned this pull request Feb 4, 2026
yaacovCR added a commit that referenced this pull request Feb 11, 2026
building on prior work:

- #3109
- #3973
- #4088
- #4223 
- #4276 

This PR adds bigint support to:
- GraphQLInt, including input/output coercion, throwing if out of
bounds, and new default value programmatic default value to literal
- GraphQLFloat, including input/output coercion, throwing if cannot be
represented, including with any loss of precision.
- GraphQLString, output coercion only, like number
- GraphQLBoolean, output coercion only, like number
- GraphQLID, output and input coercion, in parallel to number, and new
default value programmatic default value to literal

Also, for custom scalars:
- updates the `defaultScalarValueToLiteral` to convert a `bigint` to an
Int literal
- updates for deprecated `astFromValue` for passthrough custom scalars,
i.e. scalars that return `bigint` from coerceOutputValue/serialize, to
convert `bigint` to an Int literal.

cf. also #3913

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
Co-authored-by: jdecroock <decroockjovi@gmail.com>
Co-authored-by: Hkmu <3169251+hkmu@users.noreply.github.com>
Co-authored-by: xonx <119700621+xonx4l@users.noreply.github.com>
yaacovCR added a commit that referenced this pull request Feb 22, 2026
building on prior work:

- #3109
- #3973
- #4088
- #4223 
- #4276 

This PR adds bigint support to:
- GraphQLInt, including input/output coercion, throwing if out of
bounds, and new default value programmatic default value to literal
- GraphQLFloat, including input/output coercion, throwing if cannot be
represented, including with any loss of precision.
- GraphQLString, output coercion only, like number
- GraphQLBoolean, output coercion only, like number
- GraphQLID, output and input coercion, in parallel to number, and new
default value programmatic default value to literal

Also, for custom scalars:
- updates the `defaultScalarValueToLiteral` to convert a `bigint` to an
Int literal
- updates for deprecated `astFromValue` for passthrough custom scalars,
i.e. scalars that return `bigint` from coerceOutputValue/serialize, to
convert `bigint` to an Int literal.

cf. also #3913

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
Co-authored-by: jdecroock <decroockjovi@gmail.com>
Co-authored-by: Hkmu <3169251+hkmu@users.noreply.github.com>
Co-authored-by: xonx <119700621+xonx4l@users.noreply.github.com>
yaacovCR added a commit that referenced this pull request Feb 22, 2026
building on prior work:

- #3109
- #3973
- #4088
- #4223 
- #4276 

This PR adds bigint support to:
- GraphQLInt, including input/output coercion, throwing if out of
bounds, and new default value programmatic default value to literal
- GraphQLFloat, including input/output coercion, throwing if cannot be
represented, including with any loss of precision.
- GraphQLString, output coercion only, like number
- GraphQLBoolean, output coercion only, like number
- GraphQLID, output and input coercion, in parallel to number, and new
default value programmatic default value to literal

Also, for custom scalars:
- updates the `defaultScalarValueToLiteral` to convert a `bigint` to an
Int literal
- updates for deprecated `astFromValue` for passthrough custom scalars,
i.e. scalars that return `bigint` from coerceOutputValue/serialize, to
convert `bigint` to an Int literal.

cf. also #3913

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
Co-authored-by: jdecroock <decroockjovi@gmail.com>
Co-authored-by: Hkmu <3169251+hkmu@users.noreply.github.com>
Co-authored-by: xonx <119700621+xonx4l@users.noreply.github.com>
yaacovCR added a commit that referenced this pull request Feb 23, 2026
building on prior work:

- #3109
- #3973
- #4088
- #4223 
- #4276 

This PR adds bigint support to:
- GraphQLInt, including input/output coercion, throwing if out of
bounds, and new default value programmatic default value to literal
- GraphQLFloat, including input/output coercion, throwing if cannot be
represented, including with any loss of precision.
- GraphQLString, output coercion only, like number
- GraphQLBoolean, output coercion only, like number
- GraphQLID, output and input coercion, in parallel to number, and new
default value programmatic default value to literal

Also, for custom scalars:
- updates the `defaultScalarValueToLiteral` to convert a `bigint` to an
Int literal
- updates for deprecated `astFromValue` for passthrough custom scalars,
i.e. scalars that return `bigint` from coerceOutputValue/serialize, to
convert `bigint` to an Int literal.

cf. also #3913

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
Co-authored-by: jdecroock <decroockjovi@gmail.com>
Co-authored-by: Hkmu <3169251+hkmu@users.noreply.github.com>
Co-authored-by: xonx <119700621+xonx4l@users.noreply.github.com>
yaacovCR added a commit that referenced this pull request Feb 23, 2026
building on prior work:

- #3109
- #3973
- #4088
- #4223 
- #4276 

This PR adds bigint support to:
- GraphQLInt, including input/output coercion, throwing if out of
bounds, and new default value programmatic default value to literal
- GraphQLFloat, including input/output coercion, throwing if cannot be
represented, including with any loss of precision.
- GraphQLString, output coercion only, like number
- GraphQLBoolean, output coercion only, like number
- GraphQLID, output and input coercion, in parallel to number, and new
default value programmatic default value to literal

Also, for custom scalars:
- updates the `defaultScalarValueToLiteral` to convert a `bigint` to an
Int literal
- updates for deprecated `astFromValue` for passthrough custom scalars,
i.e. scalars that return `bigint` from coerceOutputValue/serialize, to
convert `bigint` to an Int literal.

cf. also #3913

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
Co-authored-by: jdecroock <decroockjovi@gmail.com>
Co-authored-by: Hkmu <3169251+hkmu@users.noreply.github.com>
Co-authored-by: xonx <119700621+xonx4l@users.noreply.github.com>
yaacovCR added a commit that referenced this pull request Feb 24, 2026
building on prior work:

- #3109
- #3973
- #4088
- #4223 
- #4276 

This PR adds bigint support to:
- GraphQLInt, including input/output coercion, throwing if out of
bounds, and new default value programmatic default value to literal
- GraphQLFloat, including input/output coercion, throwing if cannot be
represented, including with any loss of precision.
- GraphQLString, output coercion only, like number
- GraphQLBoolean, output coercion only, like number
- GraphQLID, output and input coercion, in parallel to number, and new
default value programmatic default value to literal

Also, for custom scalars:
- updates the `defaultScalarValueToLiteral` to convert a `bigint` to an
Int literal
- updates for deprecated `astFromValue` for passthrough custom scalars,
i.e. scalars that return `bigint` from coerceOutputValue/serialize, to
convert `bigint` to an Int literal.

cf. also #3913

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
Co-authored-by: jdecroock <decroockjovi@gmail.com>
Co-authored-by: Hkmu <3169251+hkmu@users.noreply.github.com>
Co-authored-by: xonx <119700621+xonx4l@users.noreply.github.com>
yaacovCR added a commit that referenced this pull request Feb 24, 2026
building on prior work:

- #3109
- #3973
- #4088
- #4223 
- #4276 

This PR adds bigint support to:
- GraphQLInt, including input/output coercion, throwing if out of
bounds, and new default value programmatic default value to literal
- GraphQLFloat, including input/output coercion, throwing if cannot be
represented, including with any loss of precision.
- GraphQLString, output coercion only, like number
- GraphQLBoolean, output coercion only, like number
- GraphQLID, output and input coercion, in parallel to number, and new
default value programmatic default value to literal

Also, for custom scalars:
- updates the `defaultScalarValueToLiteral` to convert a `bigint` to an
Int literal
- updates for deprecated `astFromValue` for passthrough custom scalars,
i.e. scalars that return `bigint` from coerceOutputValue/serialize, to
convert `bigint` to an Int literal.

cf. also #3913

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
Co-authored-by: jdecroock <decroockjovi@gmail.com>
Co-authored-by: Hkmu <3169251+hkmu@users.noreply.github.com>
Co-authored-by: xonx <119700621+xonx4l@users.noreply.github.com>
yaacovCR added a commit that referenced this pull request Feb 24, 2026
building on prior work:

- #3109
- #3973
- #4088
- #4223 
- #4276 

This PR adds bigint support to:
- GraphQLInt, including input/output coercion, throwing if out of
bounds, and new default value programmatic default value to literal
- GraphQLFloat, including input/output coercion, throwing if cannot be
represented, including with any loss of precision.
- GraphQLString, output coercion only, like number
- GraphQLBoolean, output coercion only, like number
- GraphQLID, output and input coercion, in parallel to number, and new
default value programmatic default value to literal

Also, for custom scalars:
- updates the `defaultScalarValueToLiteral` to convert a `bigint` to an
Int literal
- updates for deprecated `astFromValue` for passthrough custom scalars,
i.e. scalars that return `bigint` from coerceOutputValue/serialize, to
convert `bigint` to an Int literal.

cf. also #3913

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
Co-authored-by: jdecroock <decroockjovi@gmail.com>
Co-authored-by: Hkmu <3169251+hkmu@users.noreply.github.com>
Co-authored-by: xonx <119700621+xonx4l@users.noreply.github.com>
yaacovCR added a commit that referenced this pull request Feb 24, 2026
building on prior work:

- #3109
- #3973
- #4088
- #4223 
- #4276 

This PR adds bigint support to:
- GraphQLInt, including input/output coercion, throwing if out of
bounds, and new default value programmatic default value to literal
- GraphQLFloat, including input/output coercion, throwing if cannot be
represented, including with any loss of precision.
- GraphQLString, output coercion only, like number
- GraphQLBoolean, output coercion only, like number
- GraphQLID, output and input coercion, in parallel to number, and new
default value programmatic default value to literal

Also, for custom scalars:
- updates the `defaultScalarValueToLiteral` to convert a `bigint` to an
Int literal
- updates for deprecated `astFromValue` for passthrough custom scalars,
i.e. scalars that return `bigint` from coerceOutputValue/serialize, to
convert `bigint` to an Int literal.

cf. also #3913

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
Co-authored-by: jdecroock <decroockjovi@gmail.com>
Co-authored-by: Hkmu <3169251+hkmu@users.noreply.github.com>
Co-authored-by: xonx <119700621+xonx4l@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants