extendSchema: Do not modify standard directives#3618
extendSchema: Do not modify standard directives#3618IvanGoncharov merged 1 commit intographql:mainfrom
Conversation
IvanGoncharov
added
the
PR: bug fix 🐞
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
CI broken :( Change looks ok but somewhat unnecessary as recreated specified directive objects are identical to old directives, only necessary if for example schema modifiers are checking for specified directives via object identity rather than name, which should probably be avoided, as this "mistake" might be made by others. For example. mapSchema from graphql tools recreates specified directives... |
Fixed, you can now rerun CI on your PRs. |
Yes, but it would be a global, even in our own code: |
Sadly, GitHub UI doesn't allow to rerun it. |
|
Uncovered problems with #3611 ? |
|
CI working again -- if you want me to rebase on main and merge, just let me know. |
Without this change:
```
const extendedSchema = extendSchema(schema, parse(extensionSDL));
extendSchema.getDirective('skip') === GraphQLSkipDirective
// false
```
Maybe in future we need more comprehensive solution, but for now it's enouch to just match behaviour that we already have to standard types.
2 participants
Without this change:
Maybe in future we need more comprehensive solution, but for now it's enouch to just match behaviour that we already have to standard types.