Fix typing for `isNonNullType`#3597

Merged

yaacovCR merged 1 commit intographql:mainfrom

May 19, 2022

Contributor

yaacovCR commented May 19, 2022

= If a type is a non-null type, then the wrapped type must be nullable.

= Introduces GraphQLNullableInputType and GraphQLNullableOutputType to properly represent the result when isNonNullType is called on parameters of type GraphQLInputType or GraphQLOutputType.


          Fix typing for isNonNullType

cf6430e

= If a type is a non-null type, then the wrapped type must be nullable.

= Introduces `GraphQLNullableInputType` and `GraphQLNullableOutputType` to properly represent the result when `isNonNullType` is called on parameters of type `GraphQLInputType` or `GraphQLOutputType`.

netlify Bot commented May 19, 2022

👷 Deploy request for compassionate-pike-271cb3 pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`cf6430e`

yaacovCR requested a review from a team

May 19, 2022 17:43

github-actions Bot commented May 19, 2022

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

@github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
@github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

yaacovCR added the enhancement label

yaacovCR changed the title ~~Fix typing for isNonNullType~~ Improve typing for isNonNullType

yaacovCR mentioned this pull request

Refactor GraphQL*Type TS types to be more DRY #3598

Merged

yaacovCR added PR: bug fix 🐞 and removed enhancement labels

yaacovCR changed the title ~~Improve typing for isNonNullType~~ Fix typing for isNonNullType

Contributor Author

yaacovCR commented May 19, 2022

My guess is that this qualifies as a "bug fix" and can go into a patch release.

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

6185a3d

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on graphql#3597

Member

IvanGoncharov commented May 19, 2022 •

edited

Loading

My guess is that this qualifies as a "bug fix" and can go into a patch release.

Yes, but the patch releases don't make sense in alpha :)

IvanGoncharov approved these changes

View reviewed changes

Member

IvanGoncharov left a comment

My guess is that this qualifies as a "bug fix" and can go into a patch release.

IvanGoncharov reviewed

View reviewed changes

src/index.ts

yaacovCR added PR: feature 🚀 and removed PR: bug fix 🐞 labels

yaacovCR merged commit c526767 into graphql:main

yaacovCR deleted the dry branch

May 19, 2022 20:13

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

bbf800b

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on graphql#3597

yaacovCR added a commit that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

b97fe0a

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on #3597

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          fix GraphQLWrappingType

a5213b4

GraphQLNonNull wrapper can only be applies to nullable types

related: graphql#3597
see also: graphql#3617 (comment)

yaacovCR mentioned this pull request

fix: update remaining GraphQLNonNull<GraphQLType> codepoints to GraphQLNonNull<GraphQLNullableType> #3622

Merged

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          fix GraphQLWrappingType

4a48ef0

GraphQLNonNull wrapper can only be applies to nullable types

related: graphql#3597
see also: graphql#3617 (comment)

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to

4d63bbf

`GraphQLNonNull<GraphQLNullableType>`

This is related to graphql#3597, in the sense that graphql#3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
graphql#3617 (comment)

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to

ab5a471

`GraphQLNonNull<GraphQLNullableType>`

This is related to graphql#3597, in the sense that graphql#3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
graphql#3617 (comment)

IvanGoncharov pushed a commit that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (#3622

1de3bd3

)

`GraphQLNonNull<GraphQLNullableType>`

This is related to #3597, in the sense that #3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
#3617 (comment)

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

57ba2db

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on graphql#3597

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (gr…

64087f3

…aphql#3622)

`GraphQLNonNull<GraphQLNullableType>`

This is related to graphql#3597, in the sense that graphql#3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
graphql#3617 (comment)

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

89bd08e

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on graphql#3597

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

1ebec7c

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on graphql#3597

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (gr…

49c5784

…aphql#3622)

`GraphQLNonNull<GraphQLNullableType>`

This is related to graphql#3597, in the sense that graphql#3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
graphql#3617 (comment)

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

7cff26f

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on graphql#3597

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (gr…

f238879

…aphql#3622)

`GraphQLNonNull<GraphQLNullableType>`

This is related to graphql#3597, in the sense that graphql#3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
graphql#3617 (comment)

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

a76fe53

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on graphql#3597

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (gr…

14087b9

…aphql#3622)

`GraphQLNonNull<GraphQLNullableType>`

This is related to graphql#3597, in the sense that graphql#3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
graphql#3617 (comment)

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

edab962

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on graphql#3597

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (gr…

8896e0e

…aphql#3622)

`GraphQLNonNull<GraphQLNullableType>`

This is related to graphql#3597, in the sense that graphql#3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
graphql#3617 (comment)

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

b6223e9

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on graphql#3597

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (gr…

60ae838

…aphql#3622)

`GraphQLNonNull<GraphQLNullableType>`

This is related to graphql#3597, in the sense that graphql#3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
graphql#3617 (comment)

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

f556f8b

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on graphql#3597

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (gr…

91444bd

…aphql#3622)

`GraphQLNonNull<GraphQLNullableType>`

This is related to graphql#3597, in the sense that graphql#3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
graphql#3617 (comment)

yaacovCR added a commit that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

0b49263

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on #3597

yaacovCR added a commit that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (#3622

9b71bda

)

`GraphQLNonNull<GraphQLNullableType>`

This is related to #3597, in the sense that #3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
#3617 (comment)

yaacovCR added a commit that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

1a4a409

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on #3597

yaacovCR added a commit that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (#3622

8e08151

)

`GraphQLNonNull<GraphQLNullableType>`

This is related to #3597, in the sense that #3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
#3617 (comment)

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

efa0198

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on graphql#3597

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (gr…

6fa4a48

…aphql#3622)

`GraphQLNonNull<GraphQLNullableType>`

This is related to graphql#3597, in the sense that graphql#3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
graphql#3617 (comment)

yaacovCR added a commit that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

6abe963

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on #3597

yaacovCR added a commit that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (#3622

c3f4a29

)

`GraphQLNonNull<GraphQLNullableType>`

This is related to #3597, in the sense that #3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
#3617 (comment)

yaacovCR added a commit that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

f3f5a9f

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on #3597

yaacovCR added a commit that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (#3622

4682a22

)

`GraphQLNonNull<GraphQLNullableType>`

This is related to #3597, in the sense that #3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
#3617 (comment)

yaacovCR added a commit that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

5c613c5

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on #3597

yaacovCR added a commit that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (#3622

7c8afc1

)

`GraphQLNonNull<GraphQLNullableType>`

This is related to #3597, in the sense that #3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
#3617 (comment)

yaacovCR added a commit that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

b18793d

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on #3597

yaacovCR added a commit that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (#3622

9d34463

)

`GraphQLNonNull<GraphQLNullableType>`

This is related to #3597, in the sense that #3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
#3617 (comment)

yaacovCR added a commit that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

9e2aa40

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on #3597

yaacovCR added a commit that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (#3622

c47f67e

)

`GraphQLNonNull<GraphQLNullableType>`

This is related to #3597, in the sense that #3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
#3617 (comment)

yaacovCR added a commit that referenced this pull request


          Refactor GraphQL*Type TS types to be more DRY

850d4a3

Motivation:
1.  Makes it easier to understand the type hierarchy.
2. Adding a new type, were it ever to happen, would require fewer code changes.

Depends on #3597

yaacovCR added a commit that referenced this pull request


          fix: update remaining GraphQLNonNull<GraphQLType> codepoints to (#3622

888749f

)

`GraphQLNonNull<GraphQLNullableType>`

This is related to #3597, in the sense that #3597 made the
`GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>`
change in other code points related to the `isNonNullType` function, but
not within `GraphQLWrappingType` or assertNonNullType.

This PR was prompted by the uncovering of a bug by a different PR, see:
#3617 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: feature 🚀