Documentation for explicitly mentioning ObjectTypes - #1679
Merged
Merged
Conversation
Based on the discussion at graphql#1413
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
IvanGoncharov
requested changes
Jan 21, 2019
- provide more clear example /w interfaces & types - rewrite to note with more clarity - move the note above the note on directives
IvanGoncharov
approved these changes
Jan 22, 2019
Member
|
@buoyantair Merged 🎉 Thanks for PR 👍 |
|
Unfortunately this change didn't arrive in the documentation at https://graphql.org/graphql-js/type/#graphqlschema. Is there something else that needs to be done for that? |
Merged
yaacovCR
added a commit
that referenced
this pull request
Oct 11, 2024
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 13, 2025
would address graphql#1679 I think a simpler version than graphql#1683
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
would address graphql#1679 I think a simpler version than graphql#1683
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
would address graphql#1679 I think a simpler version than graphql#1683
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
would address graphql#1679 I think a simpler version than graphql#1683
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
would address graphql#1679 I think a simpler version than graphql#1683
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
would address graphql#1679 I think a simpler version than graphql#1683
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
would address graphql#1679 I think a simpler version than graphql#1683
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 19, 2025
would address graphql#1679 I think a simpler version than graphql#1683
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 22, 2025
would address graphql#1679 I think a simpler version than graphql#1683
yaacovCR
added a commit
that referenced
this pull request
Dec 22, 2025
yaacovCR
added a commit
that referenced
this pull request
Dec 22, 2025
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jan 27, 2026
would address graphql#1679 I think a simpler version than graphql#1683
yaacovCR
added a commit
that referenced
this pull request
Feb 22, 2026
yaacovCR
added a commit
that referenced
this pull request
Feb 23, 2026
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion at #1413