Skip to content

Added ResendConfirmation GraphQL method. #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcelicalderon merged 16 commits into from
Nov 24, 2019
Merged

Added ResendConfirmation GraphQL method. #35

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d6324c4
Updated documentation for the mutation and query graphql methods.
aarona Oct 31, 2019
898a652
Added ResendConfirmation GraphQL method.
aarona Oct 31, 2019
7e27c65
Fixed a misspelling
aarona Nov 1, 2019
ac9c1ab
Add github templates for issues (#36)
00dav00 Nov 4, 2019
ee76d39
Merge pull request #34 from aarona/mut_que_docs
mcelicalderon Nov 4, 2019
1e09349
Merged master into resend_confirmation.
aarona Nov 4, 2019
083570f
Added ResendConfirmation GraphQL method.
aarona Oct 31, 2019
9ee3fbc
Merge branch 'resend_confirmation' of https://github.com/aarona/graph…
aarona Nov 4, 2019
537e3f2
Pulled upstream master and then rebased master on send_confirmation
aarona Nov 4, 2019
2236216
Pulled upstream master and rebased master in resend_confirmation
aarona Nov 4, 2019
d1539bf
Removed rebased code to seperate the Resend Confirmation changes.
aarona Nov 4, 2019
53e7bd4
Removed rebased code to seperate the Resend Confirmation changes.
aarona Nov 4, 2019
0ced80c
Code review fixes and test enhancements per @00dav00's request.
aarona Nov 9, 2019
4e83a8b
Code review requests per @mcelicalderon and @00dav00
aarona Nov 21, 2019
58014a4
Moved reliance for Resend Instructions from Devise to Graphql Devise.
aarona Nov 23, 2019
247819e
Some RSpec styling changes per @mcelicalderon's request.
aarona Nov 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/graphql/graphql_devise/mutations/resend_confirmation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ class ResendConfirmation < Base
argument :email, String, required: true, prepare: ->(email, _) { email.downcase }
argument :redirect_url, String, required: true

field :authenticable, User, null: false
field :message, String, null: false
Comment thread
aarona marked this conversation as resolved.

def resolve(email:, redirect_url:)
Expand Down
8 changes: 4 additions & 4 deletions spec/requests/mutations/resend_confirmation_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

context 'when params are correct' do
it 'sends an email to the user with confirmation url and returns a success message' do
expect { post_request }.to(change(ActionMailer::Base.deliveries, :count).by(1))
expect { post_request }.to change(ActionMailer::Base.deliveries, :count).by 1
Comment thread
aarona marked this conversation as resolved.
Outdated
expect(json_response[:data][:userResendConfirmation]).to include(
authenticable: {
id: id,
Expand Down Expand Up @@ -54,7 +54,7 @@
before { user.confirm }

it 'does *NOT* send an email and raises an error' do
expect { post_request }.to(change(ActionMailer::Base.deliveries, :count).by(0))
expect { post_request }.to change(ActionMailer::Base.deliveries, :count).by 0
Comment thread
aarona marked this conversation as resolved.
Outdated
expect(json_response[:data][:userResendConfirmation]).to be_nil
expect(json_response[:errors]).to contain_exactly(
hash_including(
Expand All @@ -66,11 +66,11 @@
end
end

context 'when the email isn''t in the system' do
context "when the email isn't in the system" do
let(:email) { 'nothere@gmail.com' }

it 'does *NOT* send an email and raises an error' do
expect { post_request }.to(change(ActionMailer::Base.deliveries, :count).by(0))
expect { post_request }.to not_change(ActionMailer::Base.deliveries, :count)
expect(json_response[:data][:userResendConfirmation]).to be_nil
expect(json_response[:errors]).to contain_exactly(
hash_including(
Expand Down