Add Rails 8.0 support#287
Merged
mcelicalderon merged 2 commits intomasterfrom Jul 28, 2025
Merged
Conversation
mcelicalderon
force-pushed
the
mcelicalderon-add-rails-8.0-support
branch
3 times, most recently
from
5bbfc5b to
04262e4
Compare
mcelicalderon
force-pushed
the
mcelicalderon-add-rails-8.0-support
branch
from
04262e4 to
89d6dad
Compare
mcelicalderon
commented
Jul 28, 2025
Member
Author
mcelicalderon
left a comment
mcelicalderon
left a comment
There was a problem hiding this comment.
@00dav00 I have dropped some versions from the test matrix but other that that, no changes required in the gem's code to support Rails 8.0
| matrix: | ||
| parameters: | ||
| ruby-version: | ||
| - '2.7' |
Member
Author
There was a problem hiding this comment.
Test matrix exceeded the limit. I think it's fine to stop testing older ruby versions. We won't necessarily drop support now, but if we ever get a report of a failure, we can drop support then instead of fixing it. WDYT @00dav00
| `rails new gqld_dummy -S -C --skip-action-mailbox --skip-action-text -T --skip-spring --skip-bundle --skip-keeps -G --skip-active-storage -J --skip-listen --skip-bootsnap` | ||
| end | ||
| FileUtils.cd(File.join(destination_root, '../gqld_dummy')) do | ||
| `rm -f config/initializers/assets.rb` |
Member
Author
There was a problem hiding this comment.
This was necessary as the assets initializer is still generated, but additional setup is required to continue to support assets in Rails 8.0 and we don't need it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.