Add support for GraphQL 2.4#281
Merged
mcelicalderon merged 1 commit intomasterfrom Nov 29, 2024
Merged
Conversation
mcelicalderon
force-pushed
the
support-gql-2-4
branch
from
d3a973e to
ca38c6e
Compare
mcelicalderon
force-pushed
the
support-gql-2-4
branch
from
ca38c6e to
58d53cf
Compare
mcelicalderon
commented
Nov 29, 2024
| it 'skips the register mutation' do | ||
| expect(json_response[:errors]).to contain_exactly( | ||
| hash_including(message: "Field 'adminRegister' doesn't exist on type 'Mutation'") | ||
| hash_including(message: a_string_including("Field 'adminRegister' doesn't exist on type 'Mutation'")) |
Member
Author
There was a problem hiding this comment.
graphql 2.4 adds additional information to the error message. But we only care in the spec about the field not being defined in the API
Member
Author
|
@00dav00 could you please review this one? No code changes were required for this upgrade 🙌 |
00dav00
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.