Use new trace interface, remove deprecation warnings#277
Merged
mcelicalderon merged 1 commit intomasterfrom Nov 22, 2024
Merged
Use new trace interface, remove deprecation warnings#277mcelicalderon merged 1 commit intomasterfrom
mcelicalderon merged 1 commit intomasterfrom
Conversation
mcelicalderon
force-pushed
the
use-module-based-tracer
branch
4 times, most recently
from
948b8d9 to
421a687
Compare
mcelicalderon
force-pushed
the
use-module-based-tracer
branch
2 times, most recently
from
b1bc6f4 to
b3a140e
Compare
Using schema_definition.tracer(self) is deprecated so we should use the new module based tracing
mcelicalderon
force-pushed
the
use-module-based-tracer
branch
from
b3a140e to
cd8d861
Compare
Member
Author
|
@00dav00 could you please review? This should also fix master. We can add support for newer ruby versions as a follow-up as apparently this doesn't work out of the box |
00dav00
approved these changes
Nov 22, 2024
Contributor
00dav00
left a comment
00dav00
left a comment
There was a problem hiding this comment.
It looks good, just wondering if the there is a way to test the new tracer module 🤔
| @@ -0,0 +1,11 @@ | |||
| #!ruby | |||
Member
Author
There was a problem hiding this comment.
Actually that didn't work in CI. That's why I had to call the script with whatever ruby command is defined in the env.
Member
Author
Yes, probably. I can also look into that later. Apparently the gql gem will define a new class based on the module and then an instance will be created on every request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using new module based tracing mechanism to remove deprecation warnings.
Temporarily removing newer ruby versions from the test matrix as apparently some more changes will be needed to support those versions
Resolves #273