Conversation
|
|
||
| AllCops: | ||
| TargetRubyVersion: 2.2 | ||
| TargetRubyVersion: 2.3 |
There was a problem hiding this comment.
We still support ruby 2.2, if it's giving you an error locally, you have to install rubocop 0.68.1
There was a problem hiding this comment.
I know support was dropped for 2.2 but I don't see a reason to make the gem incompatible in the even someone might still be using that ruby version. But do check, if any of our dependencies already dropped support for 2.2 let's remove it. You would also need to change the version in the gemspec file
mcelicalderon
left a comment
There was a problem hiding this comment.
Looks great. I would just add the usage instructions for the generators on the Readme file. Also check if any of our dependencies lowest supported version already dropped support for ruby 2.2. If that's true we could remove it too, if not I see no reason to not keep it while it's not a major issue to maintain the gem
|
|
||
| AllCops: | ||
| TargetRubyVersion: 2.2 | ||
| TargetRubyVersion: 2.3 |
There was a problem hiding this comment.
I know support was dropped for 2.2 but I don't see a reason to make the gem incompatible in the even someone might still be using that ruby version. But do check, if any of our dependencies already dropped support for 2.2 let's remove it. You would also need to change the version in the gemspec file
mcelicalderon
left a comment
There was a problem hiding this comment.
Looks great, just minor comments
| on our own generators like this | ||
|
|
||
| The generator accepts 2 params: `user_class` and `mount_path`. The params | ||
| will be used mount the route in `config/routes.rb`. For instance the executing: |
|
|
||
| ### Mounting Routes manually | ||
| Routes can be added using the initializer or manually. | ||
| You can add a route in the following way: |
There was a problem hiding this comment.
You can add a route like this might sound better
Uh oh!
There was an error while loading. Please reload this page.