Skip to content

Add routes generator#22

Merged
00dav00 merged 12 commits intomasterfrom
add-generators
Oct 24, 2019
Merged

Add routes generator#22
00dav00 merged 12 commits intomasterfrom
add-generators

Conversation

@00dav00
Copy link
Copy Markdown
Contributor

@00dav00 00dav00 commented Oct 16, 2019

  • Add generator for routes
  • Execute devise install generator
  • Execute DTA install generator

Comment thread .rubocop.yml Outdated

AllCops:
TargetRubyVersion: 2.2
TargetRubyVersion: 2.3
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still support ruby 2.2, if it's giving you an error locally, you have to install rubocop 0.68.1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know support was dropped for 2.2 but I don't see a reason to make the gem incompatible in the even someone might still be using that ruby version. But do check, if any of our dependencies already dropped support for 2.2 let's remove it. You would also need to change the version in the gemspec file

Copy link
Copy Markdown
Member

@mcelicalderon mcelicalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I would just add the usage instructions for the generators on the Readme file. Also check if any of our dependencies lowest supported version already dropped support for ruby 2.2. If that's true we could remove it too, if not I see no reason to not keep it while it's not a major issue to maintain the gem

Comment thread .rubocop.yml Outdated

AllCops:
TargetRubyVersion: 2.2
TargetRubyVersion: 2.3
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know support was dropped for 2.2 but I don't see a reason to make the gem incompatible in the even someone might still be using that ruby version. But do check, if any of our dependencies already dropped support for 2.2 let's remove it. You would also need to change the version in the gemspec file

Copy link
Copy Markdown
Member

@mcelicalderon mcelicalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just minor comments

Comment thread README.md Outdated
on our own generators like this

The generator accepts 2 params: `user_class` and `mount_path`. The params
will be used mount the route in `config/routes.rb`. For instance the executing:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be used to mount

Comment thread README.md Outdated

### Mounting Routes manually
Routes can be added using the initializer or manually.
You can add a route in the following way:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a route like this might sound better

@00dav00 00dav00 merged commit 1c84b96 into master Oct 24, 2019
@00dav00 00dav00 deleted the add-generators branch October 24, 2019 13:55
@mcelicalderon mcelicalderon added the enhancement New feature or request label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants