Skip to content

PoC first login mutation#2

Merged
mcelicalderon merged 4 commits intomasterfrom
add-engine-base-structure
Aug 19, 2019
Merged

PoC first login mutation#2
mcelicalderon merged 4 commits intomasterfrom
add-engine-base-structure

Conversation

@mcelicalderon
Copy link
Copy Markdown
Member

No description provided.

@mcelicalderon mcelicalderon force-pushed the add-engine-base-structure branch from c1f5a12 to 6888443 Compare August 19, 2019 02:49
@mcelicalderon mcelicalderon force-pushed the add-engine-base-structure branch from 62e9d1e to 6c9ebb4 Compare August 19, 2019 05:12
@mcelicalderon mcelicalderon changed the title Add base engine structure PoC first login mutation Aug 19, 2019
@mcelicalderon mcelicalderon requested a review from 00dav00 August 19, 2019 05:49
Comment thread spec/graphql_devise_spec.rb Outdated

it "does something useful" do
expect(false).to eq(true)
it 'does something useful' do
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dow we need this?

Comment thread spec/models/user_spec.rb

expect(user.test).to eq('This is a test')
expect(user).not_to be_persisted
end
Copy link
Copy Markdown
Contributor

@00dav00 00dav00 Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about expeting that it responds to the API we will need to authenticate the user? Like active_for_authentication or create_new_auth_token?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a real test yet

@@ -0,0 +1,5 @@
module GraphqlDevise
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

@mcelicalderon mcelicalderon merged commit c77457e into master Aug 19, 2019
@mcelicalderon mcelicalderon deleted the add-engine-base-structure branch August 19, 2019 15:45
@mcelicalderon mcelicalderon added the enhancement New feature or request label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants