Add config for public introspection query on schema plugin#154
Merged
Add config for public introspection query on schema plugin#154
Conversation
00dav00
changed the title
Member
mcelicalderon
left a comment
mcelicalderon
left a comment
There was a problem hiding this comment.
Looks good! Just left 2 comments
| DEFAULT_NOT_AUTHENTICATED = ->(field) { raise GraphqlDevise::AuthenticationError, "#{field} field requires authentication" } | ||
|
|
||
| def initialize(query: nil, mutation: nil, authenticate_default: true, resource_loaders: [], unauthenticated_proc: DEFAULT_NOT_AUTHENTICATED) | ||
| def initialize(query: nil, mutation: nil, authenticate_default: true, public_introspection: true, resource_loaders: [], unauthenticated_proc: DEFAULT_NOT_AUTHENTICATED) |
Member
There was a problem hiding this comment.
Not sure true should be the default. Maybe !Rails.env.production?
| ) | ||
| end | ||
|
|
||
| after do |
Member
There was a problem hiding this comment.
Is this necessary? I think returning false will only have an effect on the context
00dav00
force-pushed
the
allow-interpreter-query-to-be-executed-without-auth
branch
from
aefcd01 to
401b9e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.