Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions lib/graphql_devise/schema_plugin.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,12 @@ def trace(event, trace_data)
# Authenticate only root level queries
return yield unless event == 'execute_field' && path(trace_data).count == 1

field = traced_field(trace_data)
provided_value = authenticate_option(field, trace_data)
context = set_current_resource(context_from_data(trace_data))
field = traced_field(trace_data)
auth_required = authenticate_option(field, trace_data)
context = context_from_data(trace_data)

if !provided_value.nil?
raise_on_missing_resource(context, field) if provided_value
elsif @authenticate_default
if auth_required
context = set_current_resource(context)
raise_on_missing_resource(context, field)
end

Expand All @@ -40,9 +39,10 @@ def trace(event, trace_data)
private

def set_current_resource(context)
controller = context[:controller]
resource_names = Array(context[:resource_name])
context[:current_resource] = resource_names.find do |resource_name|
controller = context[:controller]
resource_names = Array(context[:resource_name])

context[:current_resource] ||= resource_names.find do |resource_name|
unless Devise.mappings.key?(resource_name)
raise(
GraphqlDevise::Error,
Expand Down Expand Up @@ -88,11 +88,13 @@ def traced_field(trace_data)
end

def authenticate_option(field, trace_data)
if trace_data[:context]
auth_required = if trace_data[:context]
field.metadata[:authenticate]
else
field.graphql_definition.metadata[:authenticate]
end

auth_required.nil? ? @authenticate_default : auth_required
end

def reconfigure_warden!
Expand Down
118 changes: 118 additions & 0 deletions spec/graphql/user_queries_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
# frozen_string_literal: true

require 'rails_helper'

RSpec.describe 'Users controller specs' do
include_context 'with graphql schema test'

let(:schema) { DummySchema }
let(:user) { create(:user, :confirmed) }
let(:field) { 'privateField' }
let(:public_message) { 'Field does not require authentication' }
let(:private_message) { 'Field will always require authentication' }
let(:private_error) do
{
message: "#{field} field requires authentication",
extensions: { code: 'AUTHENTICATION_ERROR' }
}
end

describe 'publicField' do
let(:query) do
<<-GRAPHQL
query {
publicField
}
GRAPHQL
end

context 'when using a regular schema' do
it 'does not require authentication' do
expect(response[:data][:publicField]).to eq(public_message)
end
end
end

describe 'privateField' do
let(:query) do
<<-GRAPHQL
query {
privateField
}
GRAPHQL
end

context 'when using a regular schema' do
context 'when user is authenticated' do
let(:resource) { user }

it 'allows to perform the query' do
expect(response[:data][:privateField]).to eq(private_message)
end

context 'when using a SchemaUser' do
let(:resource) { create(:schema_user, :confirmed) }

it 'allows to perform the query' do
expect(response[:data][:privateField]).to eq(private_message)
end
end
end
end

context 'when using an interpreter schema' do
let(:schema) { InterpreterSchema }

context 'when user is authenticated' do
let(:resource) { user }

it 'allows to perform the query' do
expect(response[:data][:privateField]).to eq(private_message)
end
end
end
end

describe 'user' do
let(:user_data) { { email: user.email, id: user.id } }
let(:query) do
<<-GRAPHQL
query {
user(id: #{user.id}) {
id
email
}
}
GRAPHQL
end

context 'when using a regular schema' do
context 'when user is authenticated' do
let(:resource) { user }

it 'allows to perform the query' do
expect(response[:data][:user]).to match(**user_data)
end
end
end

context 'when using an interpreter schema' do
let(:schema) { InterpreterSchema }

context 'when user is authenticated' do
let(:resource) { user }

it 'allows to perform the query' do
expect(response[:data][:user]).to match(**user_data)
end
end

context 'when user is not authenticated' do
# Interpreter schema fields are public unless specified otherwise (plugin setting)
it 'allows to perform the query' do
expect(response[:data][:user]).to match(**user_data)
end
end
end
end
end
18 changes: 9 additions & 9 deletions spec/requests/user_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,6 @@
expect(json_response[:data][:publicField]).to eq('Field does not require authentication')
end
end

context 'when using the failing route' do
it 'raises an invalid resource_name error' do
expect { post_request('/api/v1/failing') }.to raise_error(
GraphqlDevise::Error,
'Invalid resource_name `fail` provided to `graphql_context`. Possible values are: [:user, :admin, :guest, :users_customer, :schema_user].'
)
end
end
end

describe 'privateField' do
Expand Down Expand Up @@ -77,6 +68,15 @@
)
end
end

context 'when using the failing route' do
it 'raises an invalid resource_name error' do
expect { post_request('/api/v1/failing') }.to raise_error(
GraphqlDevise::Error,
'Invalid resource_name `fail` provided to `graphql_context`. Possible values are: [:user, :admin, :guest, :users_customer, :schema_user].'
)
end
end
end

context 'when using an interpreter schema' do
Expand Down
14 changes: 14 additions & 0 deletions spec/support/contexts/schema_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# frozen_string_literal: true

RSpec.shared_context 'with graphql schema test' do
let(:variables) { {} }
let(:resource_names) { [:user] }
let(:resource) { nil }
let(:controller) { instance_double(GraphqlDevise::GraphqlController) }
let(:context) do
{ current_resource: resource, controller: controller, resource_name: resource_names }
end
let(:response) do
schema.execute(query, context: context, variables: variables).deep_symbolize_keys
end
end