Allow resend of confirmation with unconfirmed email#127
Merged
00dav00 merged 1 commit intographql-devise:masterfrom Aug 15, 2020
Merged
Conversation
See original handling of resend request where unconfirmed_email is looked up first when confirmable module is used: https://github.com/heartcombo/devise/blob/507573994a5524e17729f5c8e340ec6678ff26a5/lib/devise/models/confirmable.rb#L338-L341 Also, method `pending_reconfirmation?` is public in original Devise API - not sure why it must be overwritten but it should be kept public to ensure this works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See original handling of resend request where unconfirmed_email is looked up first when confirmable module is used: https://github.com/heartcombo/devise/blob/507573994a5524e17729f5c8e340ec6678ff26a5/lib/devise/models/confirmable.rb#L338-L341
Also, method
pending_reconfirmation?is public in original Devise API - not sure why it must be overwritten but it should be kept public to ensure this works.