Check reset password token mutation#10
Merged
mcelicalderon merged 2 commits intomasterfrom Sep 9, 2019
Merged
Conversation
mcelicalderon
force-pushed
the
check-reset-password-token
branch
2 times, most recently
from
eb75708 to
c6eb381
Compare
mcelicalderon
force-pushed
the
check-reset-password-token
branch
from
c6eb381 to
22c8b5b
Compare
00dav00
requested changes
Sep 9, 2019
| context[:controller] | ||
| end | ||
|
|
||
| def set_auth_headers(resource) |
Contributor
There was a problem hiding this comment.
set_auth_headers is already present in line 63 of this fiel
| private | ||
|
|
||
| def client_and_token(token) | ||
| if Gem::Version.new(DeviseTokenAuth::VERSION) <= Gem::Version.new('1.1.0') |
Contributor
There was a problem hiding this comment.
Perhaps we can create a method for this check, It is also used in client method on the base mutation
00dav00
approved these changes
Sep 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.