Apply code review suggestions

Author: David Revelo

.gitignore

@@ -16,4 +16,4 @@
 /*.sqlite3
 /spec/dummy/db/development.sqlite3
 /spec/dummy/db/test.sqlite3
-/graphql_devise-0.1.0.gem
+/*.gem

app/graphql/graphql_devise/mutations/sign_up.rb

@@ -2,15 +2,13 @@ module GraphqlDevise
   module Mutations
     class SignUp < Base
       argument :email,                 String, required: true
-      argument :name,                  String, required: false
       argument :password,              String, required: true
       argument :password_confirmation, String, required: true
       argument :confirm_success_url,   String, required: false
       argument :config_name,           String, required: false
 
-      def resolve(email:, **attrs)
-        redirect_url = attrs.delete(:confirm_success_url)
-        resource     = resource_class.new(email: email, provider: :email, **attrs)
+      def resolve(confirm_success_url: nil, config_name: nil, **attrs)
+        resource = resource_class.new(provider: provider, **attrs)
 
         if resource.present?
           resource.skip_confirmation_notification! if resource.respond_to?(:skip_confirmation_notification!)
@@ -21,8 +19,8 @@ def resolve(email:, **attrs)
             if confirmable_enabled?(resource) && !resource.confirmed?
               # user will require email authentication
               resource.send_confirmation_instructions(
-                client_config: attrs[:config_name],
-                redirect_url: redirect_url
+                client_config: config_name,
+                redirect_url:  confirm_success_url
               )
             end
 
@@ -55,9 +53,8 @@ def provider
         :email
       end
 
-      # NOTE: Devise controller method, find a way to re use it
       def clean_up_passwords(resource)
-        resource.clean_up_passwords if object.respond_to?(:clean_up_passwords)
+        controller.send(:clean_up_passwords, resource)
       end
     end
   end

app/helpers/graphql_devise/mailer_helper.rb

@@ -1,9 +1,5 @@
 module GraphqlDevise
   module MailerHelper
-    extend ActiveSupport::Concern
-
-    protected
-
     def confirmation_query(token:, config:, redirect_url:)
       raw = <<-GRAPHQL
         confirmAccount($token:ID!,$clientConfig:String,redirect:String!){

lib/graphql_devise.rb

@@ -1,7 +1,7 @@
 require 'rails'
+require 'graphql'
 require 'devise_token_auth'
 require 'graphql_devise/engine'
-require 'graphql'
 require 'graphql_devise/version'
 require 'graphql_devise/error_codes'
 require 'graphql_devise/user_error'

lib/graphql_devise/rails/routes.rb

@@ -19,7 +19,7 @@ def mount_graphql_devise_for(resource, opts = {})
       default_mutations = {
         login:           GraphqlDevise::Mutations::Login,
         logout:          GraphqlDevise::Mutations::Logout,
-        signUp:          GraphqlDevise::Mutations::SignUp,
+        sign_up:         GraphqlDevise::Mutations::SignUp,
         update_password: GraphqlDevise::Mutations::UpdatePassword
       }.freeze
 
@@ -34,7 +34,7 @@ def mount_graphql_devise_for(resource, opts = {})
           new_mutation
         end
 
-        GraphqlDevise::Types::MutationType.field("#{mapping_name}_#{action.to_s.underscore}", mutation: used_mutation)
+        GraphqlDevise::Types::MutationType.field("#{mapping_name}_#{action}", mutation: used_mutation)
       end
 
       Devise.mailer.send(:add_template_helper, GraphqlDevise::MailerHelper)

spec/dummy/app/graphql/mutations/sign_up.rb

@@ -1,5 +1,7 @@
 module Mutations
   class SignUp < GraphqlDevise::Mutations::SignUp
+    argument :name, String, required: false
+
     field :user, Types::UserType, null: true
 
     def resolve(email:, **attrs)

spec/dummy/config/routes.rb

@@ -1,6 +1,6 @@
 Rails.application.routes.draw do
   mount_graphql_devise_for 'User', at: 'api/v1', mutations: {
-    login: Mutations::Login,
-    signUp: Mutations::SignUp
+    login:   Mutations::Login,
+    sign_up: Mutations::SignUp
   }
 end