Use errors extension in sign up mutation

Author: David Revelo

app/graphql/graphql_devise/mutations/sign_up.rb

@@ -8,10 +8,6 @@ class SignUp < Base
       argument :confirm_success_url,   String, required: false
       argument :config_name,           String, required: false
 
-      field :authenticable, GraphqlDevise::Types::AuthenticableType, null: true
-      field :success,       Boolean,                                 null: false
-      field :errors,        [String],                                null: false
-
       def resolve(email:, **attrs)
         redirect_url = attrs.delete(:confirm_success_url)
         resource     = resource_class.new(email: email, provider: :email, **attrs)
@@ -32,13 +28,16 @@ def resolve(email:, **attrs)
 
             set_auth_headers(resource) if active_for_authentication?(resource)
 
-            { success: true, authenticable: resource, errors: [] }
+            { authenticable: resource }
           else
             clean_up_passwords(resource)
-            resource_errors(resource)
+            raise_user_error_list(
+              I18n.t('graphql_devise.registration_failed'),
+              errors: resource.errors.full_messages
+            )
           end
         else
-          single_error_object("Resource couldn't be built, execution stopped.")
+          raise_user_error(I18n.t('graphql_devise.resource_build_failed'))
         end
       end
 

config/locales/en.yml

@@ -1,5 +1,7 @@
 en:
   graphql_devise:
+    registration_failed: "User couldn't be registered"
+    resource_build_failed: "Resource couldn't be built, execution stopped."
     not_authenticated: "User is not logged in."
     user_not_found: "User was not found or was not logged in."
     passwords:

spec/requests/mutations/sign_up_spec.rb

@@ -17,8 +17,6 @@
           passwordConfirmation: "#{password}"
           confirmSuccessUrl:    "#{redirect}"
         ) {
-          success
-          errors
           user {
             email
             name
@@ -28,30 +26,46 @@
     GRAPHQL
   end
 
-  it 'creates a new resource that requires confirmation' do
-    expect {
-      post '/api/v1/graphql_auth', *graphql_params
-      json_response
-    }.to(
-      change(User, :count).by(1)
-      .and(change(ActionMailer::Base.deliveries, :count).by(1))
-    )
-
-    user = User.last
-    expect(user).not_to be_active_for_authentication
-    expect(user.confirmed_at).to be_nil
-    expect(user.valid_password?(password)).to be_truthy
-    expect(json_response[:data][:userSignUp]).to include(
-      success: true,
-      errors: [],
-      user: {
-        email: email,
-        name: name
-      }
-    )
+  context 'when params are correct' do
+    it 'creates a new resource that requires confirmation' do
+      expect { post_request }.to(
+        change(User, :count).by(1)
+        .and(change(ActionMailer::Base.deliveries, :count).by(1))
+      )
+
+      user = User.last
+      expect(user).not_to be_active_for_authentication
+      expect(user.confirmed_at).to be_nil
+      expect(user.valid_password?(password)).to be_truthy
+      expect(json_response[:data][:userSignUp]).to include(
+        user: {
+          email: email,
+          name:  name
+        }
+      )
+
+      email = ActionMailer::Base.deliveries.last
+      query = ERB::Util.url_encode("confirmAccount($token:ID!,$clientConfig:String,redirect:String!){userConfirmAccount(token:$token,clientConfig:$clientConfig,redirect:$redirect){success,errors}}&variables={token:\"#{user.confirmation_token}\",clientConfig:\"default\",redirect:\"#{redirect}\"}").html_safe
+      expect(email.body.encoded).to match(/query="#{query}"/)
+    end
+  end
+
+  context 'when required params are missing' do
+    let(:email) { '' }
+
+    it 'does *NOT* create resource a resource nor send an email' do
+      expect { post_request }.to(
+        not_change(User, :count)
+        .and(not_change(ActionMailer::Base.deliveries, :count))
+      )
 
-    email = ActionMailer::Base.deliveries.last
-    query = ERB::Util.url_encode("confirmAccount($token:ID!,$clientConfig:String,redirect:String!){userConfirmAccount(token:$token,clientConfig:$clientConfig,redirect:$redirect){success,errors}}&variables={token:\"#{user.confirmation_token}\",clientConfig:\"default\",redirect:\"#{redirect}\"}").html_safe
-    expect(email.body.encoded).to match(/query="#{query}"/)
+      expect(json_response[:data][:userSignUp]).to be_nil
+      expect(json_response[:errors]).to containing_exactly(
+        hash_including(
+          message: "User couldn't be registered",
+          extensions: { code: 'USER_ERROR', detailed_errors: ["Email can't be blank"] }
+        )
+      )
+    end
   end
 end