Skip to content

browser: fix flaky TestPageScreenshotFullpage #5985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mstoykov merged 1 commit into from
Jun 8, 2026
Merged

browser: fix flaky TestPageScreenshotFullpage #5985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/js/modules/k6/browser/tests/page_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,12 @@ func TestPageScreenshotFullpage(t *testing.T) {
}`)
require.NoError(t, err)

// Wait for the browser to commit a frame so the gradient div is painted
// before the screenshot is captured. Without this, on slow CI runners the
// screenshot can race the first paint and capture the still-white background.
_, err = p.Evaluate(`() => new Promise(r => requestAnimationFrame(() => requestAnimationFrame(r)))`)
require.NoError(t, err)

opts := common.NewPageScreenshotOptions()
opts.FullPage = true
buf, err := p.Screenshot(opts, &mockPersister{})
Expand Down
Loading