Skip to content

fix(packaging): install s3cmd via apt to fix k6packager image build - #5953

Merged
mstoykov merged 1 commit into
masterfrom
feature/fix-k6packager
Jun 8, 2026
Merged

fix(packaging): install s3cmd via apt to fix k6packager image build#5953
mstoykov merged 1 commit into
masterfrom
feature/fix-k6packager

Conversation

@mstoykov

@mstoykov mstoykov commented May 9, 2026

Copy link
Copy Markdown
Contributor

What?

In packaging/Dockerfile, install s3cmd from the Debian repository instead
of via pip3, and drop the now-unnecessary python3-pip dependency.

Why?

The k6packager workflow has been failing since the base image was bumped to
debian:trixie. Trixie ships Python 3.13, which enforces PEP 668, so
pip3 install s3cmd==2.4.0 is rejected with
error: externally-managed-environment.

Debian trixie packages s3cmd 2.4.0-3 — the same upstream version previously
pinned via pip — so installing it through apt keeps the version constant and
sidesteps PEP 668.

Failing run for reference:
https://github.com/grafana/k6/actions/runs/25266283376/job/74081274422

Locally verified:

  • The previous Dockerfile reproduces the CI failure.
  • The updated Dockerfile builds end-to-end.
  • s3cmd --version in the resulting image reports 2.4.0.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@mstoykov
mstoykov requested a review from a team as a code owner May 9, 2026 06:46
@mstoykov
mstoykov requested review from oleiade and szkiba and removed request for a team May 9, 2026 06:46
@mstoykov

mstoykov commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

This isn't needed for v2.0.0 as there is a working k6packager - the v2.0.0-rc1 was build with that image, while this was failing in the background.

@mstoykov mstoykov added this to the v2.1.0 milestone May 9, 2026
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing May 9, 2026 06:52 — with GitHub Actions Inactive
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing May 9, 2026 06:54 — with GitHub Actions Inactive
The packager Docker image build started failing after the base image
was updated to debian:trixie, which ships Python 3.13 and enforces
PEP 668. `pip3 install s3cmd==2.4.0` is now refused with
"externally-managed-environment".

Trixie packages s3cmd 2.4.0-3, so install it via apt and drop the
no-longer-needed python3-pip dependency.
@mstoykov
mstoykov force-pushed the feature/fix-k6packager branch from 458bd58 to 6eb3efa Compare May 9, 2026 07:08
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing May 9, 2026 07:14 — with GitHub Actions Inactive
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing May 9, 2026 07:15 — with GitHub Actions Inactive
@mstoykov
mstoykov merged commit d77597d into master Jun 8, 2026
51 checks passed
@mstoykov
mstoykov deleted the feature/fix-k6packager branch June 8, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants