Skip to content

Bump to using go1.26 and minimum 1.25 + modernize changes - #5702

Merged
mstoykov merged 2 commits into
masterfrom
bumpGo
Mar 9, 2026
Merged

Bump to using go1.26 and minimum 1.25 + modernize changes#5702
mstoykov merged 2 commits into
masterfrom
bumpGo

Conversation

@mstoykov

@mstoykov mstoykov commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

What?

Update to using 1.26 as the default, and 1.25 as the minimum version k6 supports. Also fix lint issues due to minimum 1.25 gives us some new tools.

Why?

Updating go version is required as well as lint fixes.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v1.7.0 milestone Feb 27, 2026
@mstoykov
mstoykov requested a review from a team as a code owner February 27, 2026 09:01
@mstoykov
mstoykov requested review from codebien and joanlopez and removed request for a team February 27, 2026 09:01
@mstoykov

mstoykov commented Feb 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

As usual we are waiting for 1.26.1 to be released. It seems that this is happenign on the 3rd of March so we can probably get this reviewed before that.

1.26.1 while a security update (usually) includes other bugfixes to general not security related usage

@mstoykov mstoykov added the dependencies Pull requests that update a dependency file label Feb 27, 2026
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing February 27, 2026 09:07 — with GitHub Actions Inactive
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing February 27, 2026 09:10 — with GitHub Actions Inactive
codebien
codebien reviewed Feb 27, 2026
View reviewed changes

@codebien codebien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one request

Comment thread output/cloud/expv2/output.go
o.wg.Add(1)
go func() {
defer o.wg.Done()
o.wg.Go(func() {

@codebien codebien Feb 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this change in a separated pull request so we can just merge it now and start testing it, please?

@mstoykov mstoykov Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because the linter is failing wihtout htis - this was created with golangci-lint run --fix ./...

@codebien codebien Feb 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it fail because the linter requires 1.26.x? Because if we merge wg.Go changes first then I don't get why it should fail.

@mstoykov mstoykov Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it fails, because when we now have the minimum at 1.25 we can use wg.Go - so modernize wants us to

mstoykov
mstoykov commented Feb 27, 2026
View reviewed changes
Comment thread Dockerfile Outdated
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing February 27, 2026 09:26 — with GitHub Actions Inactive
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing February 27, 2026 09:28 — with GitHub Actions Inactive
@mstoykov mstoykov mentioned this pull request Mar 9, 2026
Merged
8 tasks
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing March 9, 2026 08:48 — with GitHub Actions Inactive
codebien
codebien previously approved these changes Mar 9, 2026
View reviewed changes
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing March 9, 2026 08:50 — with GitHub Actions Inactive
joanlopez
joanlopez reviewed Mar 9, 2026
View reviewed changes
Comment thread go.mod Outdated
@mstoykov @joanlopez
Apply suggestions from code review
fd7d324 
Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com>
@mstoykov
mstoykov requested a review from joanlopez March 9, 2026 11:09
@mstoykov
mstoykov requested a review from codebien March 9, 2026 11:09
@mstoykov
mstoykov merged commit eedc0c2 into master Mar 9, 2026
42 of 44 checks passed
@mstoykov
mstoykov deleted the bumpGo branch March 9, 2026 11:10
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing March 9, 2026 11:14 — with GitHub Actions Inactive
@mstoykov
mstoykov temporarily deployed to azure-trusted-signing March 9, 2026 11:16 — with GitHub Actions Inactive
@inancgumus inancgumus mentioned this pull request Mar 12, 2026
Merged
inancgumus added a commit to grafana/k6build that referenced this pull request Mar 13, 2026
@inancgumus
Bump Dockerfile Go to 1.25.8 (#286)
c5c38ba 
- The k6-builder Docker image runs Go 1.24.4 with `GOTOOLCHAIN=local`
- k6 `master` now requires `go >= 1.25.0` (since grafana/k6#5702)
- All non-cached builds have been failing with 500 for 4 days, affecting multiple customers
- Related escalation: grafana/support-escalations#21169
@BrewTestBot BrewTestBot mentioned this pull request Mar 25, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebien codebien codebien approved these changes
@joanlopez joanlopez joanlopez approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

v1.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mstoykov @codebien @joanlopez