fix(detector): direction coverage — HARNESS_RUNTIME_PATCHING extension#24
Closed
SinatrasC wants to merge 1 commit into
Closed
fix(detector): direction coverage — HARNESS_RUNTIME_PATCHING extension#24SinatrasC wants to merge 1 commit into
SinatrasC wants to merge 1 commit into
Conversation
Targets red #126 (Evaluator state mutation): writes to Python's __builtins__ namespace let the kernel inject state visible to the entire benchmark harness. Three shapes flagged with HARNESS_RUNTIME_PATCHING (existing rule in the evaluator_state_mutation family, AUTO_FILTER): * setattr(__builtins__, name, value) * __builtins__.name = value (Attribute target) * __builtins__[name] = value (Subscript target) There is no legitimate reason for a compute kernel to write to __builtins__ — the 20 production nvfp4 false-positive cases do not touch it.
SinatrasC
temporarily deployed
to
kernelguard-api-control-plane
GitHub Actions
Inactive
KernelGuard Blue Evaluation
|
Collaborator
Author
|
Thanks for the KernelGuard Flywheel Campaign contribution. This PR is now superseded by the consolidated rule-family implementation in #273, which folds this detector coverage together with the related passing-eval variants. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Targets KG red #126 under "Direction — Evaluator state mutation". Coverage example for the previously-empty direction; the red was submitted via the direct API path and is currently
red_accepted: 1on the live leaderboard.Targets red #126 (setattr/assign on builtins).
This blue: HARNESS_RUNTIME_PATCHING extension.
Local verification
Patch was verified locally against a corpus that exercises:
plain_kernel,workspace_lazy,shape_dispatch,config_lookup,triton_jit_kernel) — all stay validKernelGuard-Red-Submission: 126