fix(detector): detect bound method replay#124
Closed
prasannakotyal wants to merge 1 commit into
Closed
Conversation
KernelGuard Blue Evaluation
|
Collaborator
|
Thanks for the KernelGuard Flywheel Campaign contribution. We are not merging this narrow variant separately because the consolidated rule-family implementation in #273 is the merge path for this detector area. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Targets KG red #144, where
custom_kernelis assigned to a bound instance method. The method saves the first input-derived result onself, then later returns that instance attribute from a call-free fast path.This adds a narrow
BOUND_METHOD_REPLAYdetector. It requires:custom_kernel = K().runorcustom_kernel = instance.runassignmentself.<attr>self.<attr>referenced by the replay guardNormal bound methods that compute from the current input, or methods that cache constant/config state, stay out of scope.
KernelGuard-Red-Submission: 144
Local verification
red_24_bound_method_replay->BOUND_METHOD_REPLAY,should_filter=Truered_24_bound_method_replayeval_blue_patch.pystayedvaliduv run python -m py_compile kernelguard.py