Skip to content

Require secret leaderboard pass for public rankings#238

Merged
msaroufim merged 1 commit into
gpu-mode:mainfrom
SinatrasC:strict-secret-leaderboard-validation
Jun 18, 2026
Merged

Require secret leaderboard pass for public rankings#238
msaroufim merged 1 commit into
gpu-mode:mainfrom
SinatrasC:strict-secret-leaderboard-validation

Conversation

@SinatrasC

Copy link
Copy Markdown
Contributor

Summary

  • Require a matching passed secret leaderboard run on the same submission and runner before public scores appear in ranking APIs, summaries, trend endpoints, rendered leaderboard SQL, and ranking notifications.
  • Add API regression coverage for public scores that pass publicly but have no secret leaderboard validation.
  • Update the local test DB fixture to include the existing app-expected leaderboard.visibility column.

Testing

  • DOCKER_CONFIG=/tmp/docker-config-anon REDIS_URL=redis://localhost:6380/0 uv run --with-requirements requirements.txt pytest -q tests/api/test_leaderboard_api.py
    • 4 passed
  • DOCKER_CONFIG=/tmp/docker-config-anon REDIS_URL=redis://localhost:6380/0 uv run --with-requirements requirements.txt pytest -q tests/api/test_leaderboard_summaries_api.py
    • 2 passed
  • git diff --check

Note

Legacy rendered-page tests under tests/test_leaderboard.py and tests/test_index.py still fail locally with 302 -> /404; this appears unrelated to the ranking SQL changes.

@msaroufim msaroufim merged commit e2e11c4 into gpu-mode:main Jun 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants