Conversation
rsheeter
changed the title
rsheeter
marked this pull request as ready for review
June 13, 2023 03:37
anthrotype
approved these changes
Jun 13, 2023
rsheeter
force-pushed
the
kern3
branch
2 times, most recently
from
June 13, 2023 20:50
f82607a to
f18f183
Compare
rsheeter
force-pushed
the
kern4
branch
3 times, most recently
from
June 13, 2023 21:32
04732ef to
b54af50
Compare
anthrotype
added a commit
that referenced
this pull request
Jul 14, 2026
#636 broke the kern group rename map: its loop compares the default master's groups against themselves, so old_to_new_group_names only ever holds identity entries and kerning referencing a non-default master's own name for a group is dropped rather than renamed. No test noticed: groups_renamed_to_match_master only pins that the merged map equals the default's groups, which holds whether renaming works or not. Assert all of the above, including the fixture premise #338 built the WghtVar groups around (Bold's the_WrOng_name = the default's correct_name members), so the tests cannot go vacuous if the fixture changes.
anthrotype
added a commit
that referenced
this pull request
Jul 14, 2026
#636 broke the kern group rename map from #338. The kerning_groups_for calls it deduplicated were never duplicates -- one loaded the default master's groups, the loop loaded each non-default source's own -- so reusing the first call's result left the loop comparing the default's groups against themselves. Since then old_to_new_group_names only ever holds identity entries, and kerning referencing a non-default master's own name for a group is dropped rather than renamed. No test noticed: groups_renamed_to_match_master only pins that the merged map equals the default's groups, which holds whether renaming works or not. Assert all of the above, including the fixture premise #338 built the WghtVar groups around (Bold's the_WrOng_name = the default's correct_name members), so a fixture change cannot quietly defuse the tests.
anthrotype
added a commit
that referenced
this pull request
Jul 14, 2026
Dead since #636 (see previous commit): the rename map only ever holds identity entries, the loop's warnings are unreachable, and validating kern references against the map's keys is equivalent to validating against the groups map directly, so do that. Remove the map (#338), the loop, and the now-unused side_ord helper; rename groups_renamed_to_match_master to groups_come_from_default_master, which is all it ever asserted. The previous commit went through CI on its own first, all checks green with the machinery still in place: https://github.com/googlefonts/fontc/actions/runs/29348074906 No output change. Divergent per-master groups get handled for real with the port of ufo2ft#996 (#339).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussion on googlefonts/ufo2ft#635, treat the group names in the default master as authorititive. Remap alternate names for the same {glyphs} in other masters. Ignore all groups from non-default masters that do not identify a set of glyphs given a name in the default.