fix: support PyPI jupyter-kernel-client>=1.0 (JupyterKernelClient rename) - #125
Open
theaathish wants to merge 2 commits into
Open
fix: support PyPI jupyter-kernel-client>=1.0 (JupyterKernelClient rename)#125theaathish wants to merge 2 commits into
theaathish wants to merge 2 commits into
Conversation
…ame) PyPI jupyter-kernel-client 1.x renamed KernelClient -> JupyterKernelClient. uv/pip installs of google-colab-cli resolve the unpinned dependency to 1.0.2, so colab exec fails with: AttributeError: module 'jupyter_kernel_client' has no attribute 'KernelClient' Resolve the client class as ColabKernelClient -> KernelClient -> JupyterKernelClient, keeping proxy_token vs token params correct.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Installing from PyPI (
uv tool install google-colab-cli/pip install google-colab-cli) resolves the unpinnedjupyter-kernel-clientdependency to 1.0.2, whereKernelClientwas renamed toJupyterKernelClient.colab execthen fails on any session (auth +colab status/colab lsstill work):Full traceback originates at
src/colab_cli/runtime.pyinColabRuntime.kernel_client(jupyter_kernel_client.KernelClient(...)).Repro (CLI 0.6.0 + PyPI jupyter-kernel-client 1.0.2):
Fix
Resolve the client class across all known variants in
ColabRuntime.kernel_client:ColabKernelClient(proxy_token=...)(git fork version)KernelClient(token=...)(PyPI <1.0)JupyterKernelClient(token=...)(PyPI >=1.0, fallback)The
JupyterKernelClientconstructor is compatible (passes through toKernelHttpManagervia**kwargs:server_url,token,kernel_id,client_kwargs,headers), verified live withcolab execafter patching.Tests
test_colab_runtime_kernel_clientto handle all three variants.test_colab_runtime_kernel_client_jupyterclient_fallbacksimulating PyPI>=1.0 (onlyJupyterKernelClientpresent).uv run pytest tests/test_runtime.py -v: 9 passed.uv run ruff check+ruff format --check: clean.echo "print('connection_test_ok')" | colab exec→connection_test_ok.