Skip to content
This repository was archived by the owner on Mar 12, 2025. It is now read-only.

fix: remove dependency on pkg_resources, moving to implicit namespaces#160

Closed
jsaladev wants to merge 1 commit into
googleapis:mainfrom
jsaladev:main
Closed

fix: remove dependency on pkg_resources, moving to implicit namespaces#160
jsaladev wants to merge 1 commit into
googleapis:mainfrom
jsaladev:main

Conversation

@jsaladev

@jsaladev jsaladev commented May 3, 2023

Copy link
Copy Markdown

pkg_resources.declare_namespace is deprecated, going for the native/implicit namespaces (PEP 420) is a much better option according to setuptools

Fixes issue #140

@jsaladev jsaladev requested a review from a team May 3, 2023 08:37
@google-cla

google-cla Bot commented May 3, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented May 3, 2023

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label May 3, 2023
pkg_resources.declare_namespace is deprecated, going for the
native/implicit namespaces (PEP 420) is a much better option
@aqeelat

aqeelat commented Jul 18, 2023

Copy link
Copy Markdown

@clundin25 can we do the same thing we did in googleapis/google-auth-library-python#1205 here?

@clundin25

Copy link
Copy Markdown

@parthea PTAL

@aqeelat

aqeelat commented Aug 1, 2023

Copy link
Copy Markdown

@parthea @clundin25 any updates?

@parthea parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a change similar to the one in googleapis/google-auth-library-python#1205

@parthea

parthea commented Nov 30, 2023

Copy link
Copy Markdown
Contributor

Fixed via #187

@parthea parthea closed this Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants