Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

chore: fix unit tests - #657

Merged
minherz merged 1 commit into
structured_loggingfrom
minherz/fix_unit_tests
Jan 16, 2022
Merged

chore: fix unit tests#657
minherz merged 1 commit into
structured_loggingfrom
minherz/fix_unit_tests

Conversation

@minherz

@minherz minherz commented Jan 16, 2022

Copy link
Copy Markdown
Contributor

To support unit testing auto-population logic, the setup of the monitored resource should do nothing if the variable is set.

to allow unit testing to customize the logic
auto-population should be skipped if monotored resource is set.
@minherz
minherz requested review from a team January 16, 2022 15:36
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: logging Issues related to the googleapis/java-logging-logback API. labels Jan 16, 2022
@minherz
minherz changed the base branch from main to structured_logging January 16, 2022 15:37
@minherz
minherz merged commit a233647 into structured_logging Jan 16, 2022
@minherz
minherz deleted the minherz/fix_unit_tests branch January 16, 2022 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/java-logging-logback API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants