Skip to content

chore(pubsub): Add sample for subscribe avro records with revisions#33900

Merged
quartzmo merged 2 commits into
googleapis:mainfrom
quartzmo:pubsub-avro-sample-revisions
May 1, 2026
Merged

chore(pubsub): Add sample for subscribe avro records with revisions#33900
quartzmo merged 2 commits into
googleapis:mainfrom
quartzmo:pubsub-avro-sample-revisions

Conversation

@quartzmo

@quartzmo quartzmo commented Apr 30, 2026

Copy link
Copy Markdown
Member

Add sample for pubsub_subscribe_avro_records_with_revisions.

The design is based on SubscribeWithAvroSchemaRevisionsExample.java:

googleapis/java-pubsub#1469

The design is based on SubscribeWithAvroSchemaRevisionsExample.java:
googleapis/java-pubsub#1469
@quartzmo quartzmo requested review from a team and yoshi-approver as code owners April 30, 2026 20:50
@snippet-bot

snippet-bot Bot commented Apr 30, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@aandreassa aandreassa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bunch of nits, but it looks good to go!

For new samples, we always strive for code readability over anything else. So that would something like no long lines, no nested arguments (within reason), descriptive comments. You got it though, LGTM!

Comment thread google-cloud-pubsub/samples/pubsub_subscribe_avro_records_with_revisions.rb Outdated
Comment thread google-cloud-pubsub/samples/acceptance/schemas_test.rb Outdated
Comment thread google-cloud-pubsub/samples/pubsub_subscribe_avro_records_with_revisions.rb Outdated
Comment thread google-cloud-pubsub/samples/pubsub_subscribe_avro_records_with_revisions.rb Outdated
@quartzmo

quartzmo commented May 1, 2026

Copy link
Copy Markdown
Member Author

@aandreassa Ruby 3.1 is no longer supported, correct? Is it OK to merge this PR despite the failing 3.1 check?

@quartzmo quartzmo merged commit a1530d7 into googleapis:main May 1, 2026
14 of 15 checks passed
@quartzmo quartzmo deleted the pubsub-avro-sample-revisions branch May 1, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants